In xmlrpctester.remote.inc, line 131 says: if($error->is_error), but if everything was ok during the xmlrpc() call, $error is NULL causing the above notice message.

CommentFileSizeAuthor
#5 1342604_notice_trying_to_get_property_5.patch1.1 KBzserno
#2 xmlrpc_notice.jpg103.21 KBzserno
#1 1342604_notice_trying_to_get_property.patch546 byteszserno

Comments

zserno’s picture

zserno commented
StatusFileSize
new 1342604_notice_trying_to_get_property.patch546 bytes

Attached patch fixes this little issue, however I'm not sure that's the most elegant solution.
Thanks for this neat module, it came quite handy for me. :)

zserno’s picture

zserno commented
StatusFileSize
new xmlrpc_notice.jpg103.21 KB

Here's a screenshot of the issue while trying to test system.listMethods.

snufkin’s picture

snufkin commented

Would that not throw an error still? Since it still tests for $error->is_error. How about this:

$error = xmlrpc_error();
if (!is_null($error)) {
  if (isset($error->is_error)) {
  }
}
zserno’s picture

zserno commented

Would that not throw an error still? Since it still tests for $error->is_error.

PHP interpreter starts evaluation from left to right so if any of the AND condition is FALSE it stops further examination, that's why it works.
Nevertheless I vote for your solution.

zserno’s picture

zserno commented
Status: Active » Needs review
StatusFileSize
new 1342604_notice_trying_to_get_property_5.patch1.1 KB

Rolled into a proper patch.

snufkin’s picture

snufkin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.