If you try to access the mobile_jquery theme settings when it is not the active theme, the includes/mobile_jquery.inc file is not loaded causing this error.

CommentFileSizeAuthor
#1 undefined-settings-1289316.patch1.47 KBrwohleb

Comments

rwohleb’s picture

rwohleb
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new undefined-settings-1289316.patch1.47 KB

Here is a patch that attempts to fix this issue. It does a few things:

  • Makes all includes include_once.
  • Makes all includes use the function format for consistency.
  • Adds an include to the theme-settings.php file.
  • Removed the use of $theme_key for base include.

I assume the use of theme_key was to try and make this easier to use as a base theme. Unfortunately it causes these types of issues. I didn't change the use of theme_key when loading module specific code because this needs to be discussed more.

lelizondo’s picture

lelizondo commented

Patch works for me. Thanks

jasonsavino’s picture

jasonsavino commented
Assigned: Unassigned » jasonsavino
Status: Needs review » Closed (fixed)

applied patch and committed change