Closed (fixed)
Project:
Views Boxes
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
22 Sep 2011 at 18:21 UTC
Updated:
6 Oct 2011 at 20:11 UTC
Jump to comment: Most recent file
This can be tested by adding some print memory_get_usage statements to cache_setting() and doing a "drush cc all". There are 2 issues in this routine:
1) Calling views_get_view with the last argument TRUE causes the entire view to be loaded. This argument should be FALSE. True, it might return the block cache setting of the previously cached view, but that's pretty rare compared to the cost of loading the entire view again.
2) Calling set_display also causes Views to use lots of memory. Instead, the supplied patch (given below) shows how to loop through the displays and find the block_cache option.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fix-cache-1287880-2.patch | 908 bytes | mpotter |
| #1 | fix-cache-1287880-1.patch | 851 bytes | mpotter |
Comments
Comment #1
mpotter commentedHere is the patch for the above issues.
Comment #2
mpotter commentedActually, here is an improved patch that fixes a error when the cache setting cannot be found.
Comment #3
tirdadc commentedMuch, much better. Tested this and it makes a tremendous difference. It's committed now and in the beta5 release, thanks again!