What is the purpose of this CSS rule ?

#tasks-view-filter-form label {
	margin-bottom:-1.6em;
}

It hides the Showing 14 tasks. Filter: line.

CommentFileSizeAuthor
#4 tasks.css_.128510.patch605 bytesscor
#3 tasks_remove_css.patch573 bytesadd1sun

Comments

moonray’s picture

moonray commented

What browser are you using? On firefox it removes the extra space between the label and the select box.

scor’s picture

scor commented

Ok, it's because of my theme.
I think that instead of using 

#tasks-view-filter-form label {
  margin-bottom:-1.6em;
}

something like

#tasks-view-filter-form .form-submit {
  margin:0;
}

would make more sense as you wouldn't have to play with the negative margin.

add1sun’s picture

add1sun commented
Status: Active » Needs review
StatusFileSize
new tasks_remove_css.patch573 bytes

Actually I think the only thing we need on the filter-form is this maybe this one:
#tasks-view-filter-form .form-item, #tasks-view-filter-form input {
margin-bottom:0;
}
The others really aren't necessary as far as I can see (and then the margin displays properly in FF without needing negative margins).

I've attached a patch that changes the css file to this. It displays fine for me (without extra space) on IE and FF.

scor’s picture

scor commented
Version: 5.x-1.0 » master
StatusFileSize
new tasks.css_.128510.patch605 bytes

Your patch works fine add1sun, but I think it makes more sense to have the filter button on the same line as the drop down list. patch against HEAD attached.

scor’s picture

scor commented

I forgot to mention I tried my patch on FF and IE; on my own theme, blue marine and garland.

scor’s picture

scor commented
Status: Needs review » Fixed

fixed in HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)