Does anyone have this module, 6.x version, working with advanced help? I just get an empty popop. I've tried recommended releases and dev. Just a plain drupal 6 install with only adv help, beauty tips installed.

Just curious.

EDIT: It seems that jquery_update breaks things. Turn that off, works again. Wonder why?

Comments

kleinmp’s picture

kleinmp commented
Status: Active » Fixed

I fixed this in the dev version of the 6 branch. The css selector wasn't working correctly with the newer version of jquery. I removed the exclusion of the advanced help navigation to fix this. I couldn't seem to grab everything except the navigation, and I figured it would be better to grab more than is needed

kleinmp’s picture

kleinmp commented

Also, I fixed another advanced help issue for the drupal 7 version where it would not disaply the advanced help icon.

chrisschaub’s picture

chrisschaub commented

Thanks, works well. I do notice that it works on "hover" which is great, but if you click, you get the standard advanced help popup box. Is this supposed to work this way?

chrisschaub’s picture

chrisschaub commented

As a further thought, shouldn't the default be in includes/drupal_help.inc:

current code:

  if (user_access('view advanced help popup')) {
    drupal_add_css(drupal_get_path('module', 'advanced_help') . '/help-icon.css');
    return l($text, "help/$module/$topic", array(
      'attributes' => array(
        'class' => $class,
        'onclick' => "var w=window.open(this.href, 'advanced_help_window', 'width=". $info['popup width'] .",height=". $info['popup height'] .",scrollbar
s,resizable'); w.focus(); return false;",
        'title' => $info['title']
      ),
      'query' => array('popup' => TRUE),
      'html' => TRUE)
    );
  }

slight tweak/revision to make the advanced help popup not fire along with beautytip:

  if (user_access('view advanced help popup')) {
    drupal_add_css(drupal_get_path('module', 'advanced_help') . '/help-icon.css');
    return l($text, "help/$module/$topic", array(
      'attributes' => array(
        'class' => $class,
        'onclick' => "return false;",
        'title' => $info['title']
      ),
      'html' => TRUE)
    );
  }

otherwise, when you click the advanced help option you get both the beauty tip AND the advanced help popup which I'm assuming is not desired?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Found reason for break.