GB Specific Changes [#1219658]

Comment	File	Size	Author
#9	patch_commit_570b6cfa3503.patch	2.34 KB	jdelaune
#8	patch_commit_d755f81eff37.patch	2.27 KB	jdelaune
#6	gb_address_format_1219658-2.patch	3.04 KB	cameron tod
#1	gb_address_format_1219658.patch	1.87 KB	fonant
	patch_commit_7154c3b7452a.patch	1.57 KB	jdelaune

Comment #1

fonant commented 15 July 2011 at 17:57

Status	File	Size
new	gb_address_format_1219658.patch	1.87 KB

Here's my take on the patch for UK addresses.

County field is present but optional (Royal Mail don't use it if Postcode is present). So I don't think we need to ask the user to select from a long list of counties: this is unneeded, and also has the problem of whether to use old-fashioned or new county names.

Formatting of address output also improved, with new lines as normal.

Log in or register to post comments

Comment #2

cameron tod commented 14 August 2011 at 12:50

Thanks Fonant, this patch makes a lot more sense for UK addresses. Would love to see it applied in the next release version.

Log in or register to post comments

Comment #3

jdelaune commented 23 August 2011 at 16:25

So what needs to get discussed? The code could certainly be cleaned up a bit. But overall it seems good. Anything else holding it back from a commit?

Log in or register to post comments

Comment #4

fonant commented 2 September 2011 at 17:09

Just to say be careful cleaning up the code: the locality_block has a style sheet attached to it, so it needs to remain in place even if not displayed. Probably would be better to move the style sheet include somewhere else?

Sadly the UK address format is so completely different to other places in the world, it didn't seem possible to fiddle things without doing this complete re-arrangement for the UK. At least the UK-specific stuff is all in one place!

Log in or register to post comments

Comment #5

cameron tod commented 25 September 2011 at 12:15

There's bug in this patch where the postal code is added to the form twice. I have fixed it locally and will re-roll a new patch shortly.

Log in or register to post comments

Comment #6

cameron tod commented 25 September 2011 at 12:45

Status:

Active

» Needs review

Status	File	Size
new	gb_address_format_1219658-2.patch	3.04 KB

Attaching patch.

Log in or register to post comments

Comment #7

flortjes commented 29 September 2011 at 19:34

Seems like we've got this issue twice! I've just submitted a patch for issue #939394: Support for UK addresses and then stumbled upon this one.

Log in or register to post comments

Comment #8

jdelaune commented 30 September 2011 at 14:01

Status	File	Size
new	patch_commit_d755f81eff37.patch	2.27 KB

Hopefully this one will pass the patch police :P

I've tried to minimise the amount of changes it does to the structure of the form elements. I've added an extra class so we can tweak the arrangements of elements for country specific needs such as this.

Fingers crossed :)