User roles should be read/changed via user_load() and user_save(), not directly in database

Using user_save() gives other modules an opportunity to react to role changes. It looks like role_expire sets expirations on hook_user, for example, so you wouldn't need to do that directly if you used user_save().

user_load() is already called on the global $user, so requesting the roles again is an unnecessary database request.