grep -nr "#title.*')," * | wc -l: 368
grep -nr "#title.*\.')," * | wc -l: 16

I noticed today that "Allow multiple values." had a full stop, and it bugged me. So I fixed it, and the rest of them.

CommentFileSizeAuthor
#6 views-1182762-6.patch7.89 KBtim.plunkett
#5 views-1182762-5.patch7.86 KBtim.plunkett
#1 views-1182762-1.patch11.48 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new views-1182762-1.patch11.48 KB

Attached.

merlinofchaos’s picture

merlinofchaos commented

Is there a standard on checkboxes, though?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

http://awesomescreenshot.com/0feehz8c5 is admin/structure/views/settings, no periods there.

But http://awesomescreenshot.com/0d3ehzb0f, admin/config/development/performance, has no periods on the top checkboxes and some on the botttom.

merlinofchaos’s picture

merlinofchaos commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-3.x.

A 6.x-3.x similar patch should probably also be done. I'd say not technically a port, but redoing the same search.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new views-1182762-5.patch7.86 KB

Only 11 this time.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1182762-6.patch7.89 KB

Adjusted commit message to match other commit, maybe I'll get credit this time :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Looks fine.

Commited to 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.