The function in sparql.inc includes a file we removed over a month ago, and I don't see the purpose of the function, so I recommend removing that file and the hook_init implementation that includes it.

CommentFileSizeAuthor
#3 remove-sparql-inc-and-hook-init-1175628-3.patch1.72 KBclayball

Comments

clayball’s picture

clayball commented
Assigned: Unassigned » clayball

So the hook_init function should not include, require_once, anything?
or should the reference to sparql.client.inc just be removed from sparql.inc?

clayball’s picture

clayball commented

I think I answered my own question. I can submit a patch for sparql.module soon :-)

clayball’s picture

clayball commented
StatusFileSize
new remove-sparql-inc-and-hook-init-1175628-3.patch1.72 KB

patch created.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Reviewed & tested by the community

Great, thanks Clay!

Looks good to me. I'm going to RTBC it so Steph can take a look too.

scor’s picture

scor commented
Status: Reviewed & tested by the community » Fixed

Thanks Clay for the patch! Fixed with http://drupalcode.org/project/sparql.git/commit/c1afa97

Automatically closed -- issue fixed for 2 weeks with no activity.