Some improvements
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | rubik+omega-1155186-7.patch | 2.19 KB | coffeymachine |
| #6 | rubik+omega-1155186-6.patch | 1.71 KB | coffeymachine |
| #4 | rubik+omega-1155186-4.patch | 1.13 KB | coffeymachine |
| 1.jpg | 101.12 KB | protools |
Some improvements
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | rubik+omega-1155186-7.patch | 2.19 KB | coffeymachine |
| #6 | rubik+omega-1155186-6.patch | 1.71 KB | coffeymachine |
| #4 | rubik+omega-1155186-4.patch | 1.13 KB | coffeymachine |
| 1.jpg | 101.12 KB | protools |
Comments
Comment #1
fubhy commentedYep, that is indeed a problem (noticed that a few times already too) but its not a Omega Issue, its a problem with Rubik and how it handles nested Fieldsets :(
Comment #2
himerus commentedYes, it is sad.... I was a HUGE fan of Rubik... However, I've recently switched to using the core provided Seven theme for administrative pages.
It does look like there was an update for Rubik in March, but historically, they've been VERY slow to update anything in the D7 version.
Comment #3
anniegreens commentedI'm reassigning the project on this issue to Rubik, as it appears to be caused by Rubik's handling of nested/collapsible fieldsets.
Attached are screenshots of two vertical tab fieldsets from Omega's theme configuration page. The screenshots from Rubik show broken handling and the screenshots from Seven show correct handling.
This may be a simple CSS fix. I will dig into it a little deeper this afternoon.
EDIT: d.o seems to be having issues. I cannot successfully upload all attachments at this time. Please find the images here: http://imgur.com/a/ZPGVY#9ObAB
Comment #4
coffeymachine commentedHere is a patch for this, based on the dev branch. If someone could sanity check my work and make sure I didn't break anything else, that would be awesome. :)
Comment #5
himerus commentedI will check this next time in front of a Rubik/Omega install... (tomorrow) :)
I did some playing myself on some CSS that "sorta" got it to work in Rubik, but broke the nested fieldsets outside of any Rubik admin, so I scrapped my effort.
Comment #6
coffeymachine commentedAfter some further testing this morning, I discovered some issues with non-collapsible fieldsets that the patch created. I fixed those, here is a new patch.
Comment #7
coffeymachine commented...aaand I found some new issues with this patch and the Views admin UI. I fixed them here in this version.
Comment #8
wavesailor commentedFYI: It only seems to break in Firefox and not Chrome. Unfortunately it's the only browsers I use.
Comment #9
himerus commentedI can verify that the patch from #7 fixes the layout issues w/nested fieldsets in an omega theme settings page.
Sorry it took me so long to getting around to test it.
Comment #10
markhalliwellI can attest to this problem as well, is there any time frame on when this might get pushed?
Thanks!
Comment #11
Tezza commented#7 works for me too. Thanks c-machine, that saved me from applying my own targeted but sloppy negative top margin fix.
Comment #12
coffeymachine commentedThanks for testing everyone. The patch is now committed.
Beta7 release also coming shortly...