Hello,
I'm using cron to send notifications and also testing held posts before sending. I recently upgraded to the current cvs version to get over a previous bug (http://drupal.org/node/106871) but am now seeing two errors in my drupal logs whenever notifications goes out.

The first one, triggered with cron.php:

implode() [function.implode]: Bad arguments. in /home/clients/ymb/public_html/sandbox/modules/node.module on line 363.

The second also triggered from cron.php:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /home/clients/ymb/public_html/sandbox/includes/database.mysql.inc on line 121.

The notifications still go out but I wanted to alert about these errors.

Comments

jackdaw’s picture

I see this too, with version 5.x-1.6

warning: Invalid argument supplied for foreach() in ...

warning: implode() [function.implode]: Bad arguments. in ...

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in ...

Etc. Everything seems to work, but the pagelong error message is frightening.

This is a standard Drupal 5.1 test installation with only the subscriptions module added

mindless’s picture

Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Assigned: Unassigned » mindless
Status: Active » Fixed

oops, i didn't realize the $node->taxonomy value is totally different in the nodeapi 'insert' hook than it is when you node_load a node. fixed up that code in DRUPAL-5 branch. hopefully fixed on DRUPAL-4-7 branch too.

jackdaw’s picture

Yes, the error messages are gone now, thank you.

But for some reason, I now get no subscription emails either. I ran the upgrade.php, and the cron.php too (in case it had anything to do with this module). Hmm, difficult decision, errors or no email ...

jackdaw’s picture

Doub, sorry... I forgot that I was commenting with the same user, and therefore wasn't notified about my own posts. Nice feature by the way. Everything works fine now :"-)

coltrane’s picture

I upgraded to the 1.38.2.3.2.36 2007/03/02 version of 4.7 branch and am not seeing the errors anymore. Thank you!

Anonymous’s picture

Status: Fixed » Closed (fixed)