Looking at the code for st() in Drupal 7, it does support contexts. However, the parsing code in potx does not support for that. We should fix that. $t() is a common shorthand for st() or t(), so that should be fixed too.

CommentFileSizeAuthor
#1 st-context-parsing.patch8.37 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new st-context-parsing.patch8.37 KB

Attached patch implements support for this and includes test coverage. Also found this issue while building tests for this: #1039552: Add test coverage for context support in format_plural().

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Ok, committed to Drupal 7.x-1.x. Need to be backported.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Patch (to be ported) » Fixed

Same patch applied cleanly to Drupal 6 version, committed there too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.