This module requires classTextile.php to work, but unfortunately, using require_once() causes your site to WSOD if the file is not present.

This has bitten me lots of time, since upgrading modules with drush will result in this file missing, as it does not ship with the module, and suddenly the site is broken and no one knows why.

I suggest you use include_once() instead, since that will not break the site completely, but instead provide nice error messages in the watchdog log (missing includes is a non-fatal error), making the problem much easier to diagnose.

Comments

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented

+1 :-)

Anonymous’s picture

Anonymous (not verified) commented
Title: Use include_once() instead of require_once() to avoid WSOD if classTextile.php is not present » Change the code to avoid a WSOD if classTextile.php is not present

The code should actually use module_load_include() and verify if the library file exists before to try to load it.
The implementation of hook_requirements() should be sufficient to report to the administrators the reason why the module is not working.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

Thank you for your report. I have changed the code, committed it, and created a new official release (http://drupal.org/node/1032146).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.