The call to the print stylesheet is not correct and generates a 404 in the logs

<style type="text/css" media="print">@import "/modules/sifr/sifr/sifr-print.css";</style>

It should be

<style type="text/css" media="print">@import "/modules/sifr/sifr/sIFR-print.css";</style>
CommentFileSizeAuthor
#12 sifr_2.patch807 bytesac
sifr_1.patch842 bytesac

Comments

canadrian’s picture

I was experiencing this as well. I did a find/replace on all the sifr module files to replace sifr-print.css with sIFR-print.css, and sifr-screen.css with sIFR-screen.css. However, the module still appears to do nothing at all. None of the text is replaced, and my watchdog is still kicking up the error:

Type	page not found
Date	Sunday, January 14, 2007 - 23:56
User	Canadrian
Location	http://electricteaparty.net/if(typeof%20sIFR%20==%20%22function%22)%20%7B%20%20sIFR.replaceElement(%22
Referrer	http://electricteaparty.net/admin/settings/sifr/addrule
Message	if(typeof sIFR == "function") { sIFR.replaceElement("
Severity	warning
Hostname	198.166.63.235

This module would be fantastic if I could get it to work. :) Any ideas?

ac’s picture

Use the patch I provided

canadrian’s picture

LOL I haven't the foggiest idea how to apply a patch file. :)

canadrian’s picture

Ok, I found how to apply patch files in the Drupal handbook. I downloaded a nice, fresh, steaming copy of this module, and applied the patch with the command-line. I uploaded it to the module directory (I'm using sites/default/modules/sifr), and I refreshed the "Add a new sIFR rule" page. Still no dice - all I get is plain text, and the watchdog is still recording the error I posted above. Hmm....

ac’s picture

You did also download the external sIFR library and put that in your modules/sifr directory right? sIFR Module relies on the functionality provided by the sIFR JavaScript/Flash library (downloaded separately). http://www.mikeindustries.com/blog/files/sifr/2.0/sIFR2.0.2.zip

canadrian’s picture

Yes, I did realize I had to download that package, no thanks to the readm--- oh wait, there was no readme. But I did figure it out when the modules page kicked up an error telling me to install it. Anyhoo, the contents of the sifr package (minus the uncompressed source files) are in sites/defailt/modules/sifr/sifr

ac’s picture

Hmm, not sure what the issue is. I would suggest either creating a new ticket or a forum post. Might even want to jump on #drupal-support. Due to the name of this issue I don't think you will get anyone else helping here.

jjeff’s picture

Status: Active » Fixed

This has been fixed in both DRUPAL-5 and DRUPAL-4-7 branches.

Anonymous’s picture

Status: Fixed » Closed (fixed)
sun’s picture

Status: Closed (fixed) » Patch (to be ported)

hmmm... not really. DRUPAL-4-7 says:

      theme('add_style', $path .'sIFR-print.css', 'print');
sun’s picture

Status: Patch (to be ported) » Fixed

Comitted to 5.x-dev and 4.7.x-dev.

ac’s picture

StatusFileSize
new807 bytes

This is still active in 5.x-dev. Please commit. The naming of the files by Mike Industries is very confusing with the uneeded capitals.

sun’s picture

Awkward. Thanks, ac!

Anonymous’s picture

Status: Fixed » Closed (fixed)