Allow breadcrumbs and feed icons to be toggled in admin UI

This is clearly a won't fix, you can do this in the theme layer.

subscribe

I'm going to presume to open this back up for further discussion. It's true you can do this in the theme layer, but the same is true of the logo, site name, slogan, and everything else that can be toggled on this screen; and probably all the arguments for including those settings also apply to breadcrumbs. For example, what if you're using a core theme and shouldn't modify the code? Or what of clients and non-technical users who can't? I actually think this is an obvious win.

The patch no longer applies, so I re-rolled it, and the change works great. Great job, @JStarcher. I did change it just a bit to conditionally include a has-breadcrumb body class in addition to no-breadcrumb. (Themer's should have a positive as well as a negative hook.)

For Bojhan and others who believe that it should be done in the theme layer: think about Stark. I will just repeat here what I said in a similar feature request (http://drupal.org/node/1507272) before I saw this issue here. Imagine a user who installs Drupal, makes some content using a built-in theme, and something is added to that user's content. Every other item of that kind (like logo, as well as "Powered by Drupal" block, etc.) can be toggled on or off from within Drupal. Breadcrumbs (which the user did not expect to be added) cannot, if the theme has no template. So the user would be forced to (a) change the theme (or create a new theme, based on Stark but having a template with div's etc.), or (b) play with the core to prevent Drupal from producing breadcrumbs , or (c) download and use an additional module (like I have done).
I may be wrong (all in all, I am a Drupal newbie :)), but in my view there is something wrong in this situation.
I definitely vote for this feature request.

Your assessment is pretty accurate, @Maksym Kozub. What we need now is for people to test the patch and report back here. It's a pretty trivial change, so we just need a couple of people to confirm it works. Then we can mark the issue RTBC, and it will have a chance to be committed by the core team.

Welcome to Drupal. Thanks for getting involved! :)

This is such a simple patch. Can anybody test it?

Sorry Travis, I haven't been here for a while. I cannot say anything about 8.x-dev, but I have tested it now against 7.14 (applying it manually), and it works properly on my production site. (It is a very simple one, without lots of modules etc. I hope somebody will test it with more sophisticated Drupal installations.)
Many thanks to both Jordan and Travis!

Ya know what? As long as we're in there, let's make the feed icons togglable, too.

I'm removing the breadcrumb body classes. If a core developer thinks they should be in there, they can be put back in.

Updated issue summary.

Tagging.

The patch in #12 still works as of today. Anybody else had a chance to test it? It would be nice to RTBC this and move it forward.

Not working 100% for me under 8.x. Patch 12 applies cleanly against 8.x, and the added options do appear in admin/appearance/settings. However, the toggles aren't doing anything for me; the patch removes breadcrumbs and feed icons whether toggled or not.

Tested against a fresh sandbox site installed and patched through git. The breadcrumbs and feed icons appeared as normal before the patch.

Forgot to run update.php before. Now everything works as expected.

Code looks good and works as advertised. Tested under Bartik and Stark

RTBC?

Re: @samhassell, for such a small change I would go ahead and RTBC it. We've had a few people confirm that it works, so now we just need a committer's opinion, and an RTBC status is the way to get that attention. Thanks!

I don't really see this being necessary, so lets get committer feedback on this.

Updated issue summary.

Added argument and counter arguments against the feature to the issue summary.

Here's an updated patch against the current state of 8.x.

Okay; let's see what the testbot thinks about this.

The last patch didn't apply cleanly so I've rerolled it and attached it here.

While I was testing, I noticed that Breadcrumbs in Drupal 8 can be managed/disabled by the blocks interface. Here's the change record for that feature.

This makes me think the the ability to turn off breadcrumbs in the theme settings isn't so important and is possibly duplicative. I'd be interested to hear any opinions on whether this patch should remain the same, or if it ought to be trimmed down to just handling the RSS aspect.

23: drupal-theme-toggles-1256994-23.patch queued for re-testing.

Hi. I'm at Amsterdam code sprint and can work on this issue with roborew, stephen-cox, kiliweb and lwilliams.

pls check #2306407: Remove breadcrumb from page template before working on it, since the part with breadcrumbs can't be resolved without solving the referenced issue

We've re-rolled the patch, for review. But look like this feature will be removed, so probably not worth applying.

There's no interdiff because the previous patch didn't apply.

fixing the amsterdam sprint tag to amsterdam2014

I don't think these things need to be settings in the framework. Especially not if we're going to make breadcrumbs blocks in #2306407: Remove breadcrumb from page template. It's ok if individual themes want to expose this as settings though. All things considered, this is a "won't fix".