Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
datetime.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Aug 2014 at 23:41 UTC
Updated:
19 Sep 2014 at 20:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #3
sunLooks great — some early feedback:
Any particular reason for using different method names?
Why don't we consistently use
validate()?Can we always locate
process()abovevalidate(), so that the methods on the element classes are declared in the order in which they are invoked?Also, as above, ditto for
processDateTime()→process()Comment #4
tim.plunkettThey were originally called datetime_datetime_validate and datetime_datelist_validate. And who knows what other #element_validate might exist in the future. So not renaming those just yet.
The interdiff looks REALLY messy because git is trying to match { and } or something, when I'm really just moving the methods.
Also fixed the base class.
Comment #6
tim.plunkettWow, that was an unfortunate copy/paste. '#maxlength' completely breaks datetime.
Comment #8
tim.plunkettSee #2328061: Move datetime's FormElement #type classes in Core, if we decide to go that route this is a dupe.
Comment #9
tim.plunkett