Closed (fixed)
Project:
jQuery Update
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Oct 2013 at 14:07 UTC
Updated:
19 Nov 2014 at 05:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sylus commentedAttaching patch...
Comment #2
sylus commentedComment #3
rkallensee commentedI experienced the same issue - I wasn't able to load jQuery UI effect JS files e.g. via
drupal_add_library('system','effects.slide');because the filenames changed in jQuery UI 1.10.x.But the previous patch didn't work for me because I think it's important to preserve the keys as specified in system_libraries() while loading the JS files from the new location.
I added another patch where the path segments for the UI effect JS files are specified explicitly.
Comment #4
raphaelhuefner commentedI took a look where and how the file name mapping array which gets improved in the 2 previous patches gets used and discovered that it is not just a mapping from old filenames to new ones, but that there are up to 3 different strings involved:
I made a patch for this which is rolled against https://drupal.org/commitlog/commit/3224/65eecb0f1fc69cf6831a66440f72e33...
Comment #5
hefox commentedFixed it, though looks like some commented out code in the patch?
Comment #6
havran commentedI have this problem with autocomplete_deluxe (jquery_update-7.x.-2.x from 2013-Oct-14, + autocomplete_deluxe-7.x-2.x-dev from 2013-Nov-26). I use autocomplete_deluxe for freetaging taxonomy field in my content type.
Error in Google Chrome console:
Failed to load resource: the server responded with a status of 404 (Not Found) http://admin.hnonline.dev/sites/all/modules/contrib/jquery_update/replac...
Uncaught TypeError: Cannot set property '_resizeMenu' of undefined
I try use patch from #4 but without success.
Comment #7
raphaelhuefner commentedre #5 @hefox Are you referring to the patch from #4?
Please bear with me on this one, it's kinda hard to explain:
It only looks like commented code on first glance. That is an "optical illusion" produced by the way how
git diffis producing patches: It does not consider logical code units like foreach loops, function declarations etc. , just individual lines. And the starting lines of the doc comments of the inserted function and of the immediately following function just look the same togit diff, so it applies it's "changed line" logic right smack in the middle of the doc comments. Hence the optical illusion.Once this patch actually gets
git applyed, it will become more apparent what I was trying to explain here. Sorry again!-----
re #6 @havran How exactly did the #4 patch fail for you?
Please provide more details, like for instance the (error) output of
patch -p1 < jquery_effects_missing-2123973-3_0.patchorgit apply --verbose jquery_effects_missing-2123973-3_0.patch.Did you clear caches after applying the patch?
... Etc.
Without sufficient details:
A) Your problem can not be fully understood (and hopefully solved!) by other people looking at this issue.
B) It can not reliably be determined whether in your observation #6 the patch is at fault or not.
Comment #8
hefox commentedI'm going ahead and RTBC this since encountered it again on a different project.
I really don't see the line I thought was commented out code now (I look at a lot of patch files).
Comment #9
acbramley commentedI can't review the logic in this patch but it did fix my issues where a jquery 1.10.x version of an effects file was trying to be included when I had set jquery 1.7 up for admin pages.
Comment #10
ericduran commentedI think the file name is just wrong?
I think it might be easier to do that then the patch. Thoughts?
Comment #12
ericduran commentedThis is now Fixed.
Change set should show up soon.
Thanks.
Comment #14
sylus commentedI had to attach the commit that was made as a patch here so I could leverage it in my drush make while keeping jquery_update to stable.
Comment #15
sokrplare commentedRan into this issue in Hierarchical Select (#873170: HS + jQuery UI 1.8.2 compatibility) - any chance a 2.5 release will come out so less people have contrib module compatibility problems? Looking at that thread a decent amount of time was spent trying to track down just because people were running 7.x-2.4. Thanks for getting a patch on this too, btw!
Comment #16
othermachines commentedThanks for the patch, @sylus.
Comment #17
lklimek commentedI had some issues applying patch #14 so I've re-rolled it against 7.x-2.4.
Comment #18
damienmckennaComment #19
avig commentedOn the jQuery Update configuration page I changed the "Alternate jQuery version for administrative pages " from Default jQuery version to Default provided by Drupal.
This removed the error I had.