Updated: Comment 0
Problem/Motivation
We needed to fork doctrine/common for a while.
Proposed resolution
Undo it.
most of these noise is comming from the recent composer version.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | doctrine-2173719.patch | 27.97 KB | dawehner |
| #8 | common-2173719-8.patch | 24.82 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettLooks good to me.
Comment #2
catchBumping status a bit, good to keep things like this straight.
Comment #3
dries commentedThis appears to add a PSR-4 class loader which would make this major.
Comment #4
dawehner@Dries
The current composer version always uses a PSR-4 class loader, given that PSR-0 is just a subset.
You cannot specify to use a PSR-0 only class loader, though as long we don't change anything inside drupal itself, it won't register the namespaces in a PSR-4 way.
Comment #5
webchickJust an innocent question, please do not stab me. Is it possible to do this without upgrading composer at the same time? Makes the patch a no-brainer to get in.
Comment #6
dawehnerSee #2172235-9: Upgrade Twig to 1.15.* from 1.12.*
That was my honest opinion here.
Comment #7
tim.plunkett#2175447: Update composer to latest version
Comment #8
tim.plunkettComment #9
webchickOk, cool, #2175447: Update composer to latest version is in, this one will need a small re-roll. Feel free to bump back to RTBC once that's done.
Comment #10
dawehnerRerolled.
Comment #11
damiankloip commentedSeems pretty straight forward to me.
Comment #12
catchCommitted/pushed to 8.x, thanks!
Comment #14
mile23Wondering if we can just bump this up to a straightforward version requirement here: #2375997: Avoid tying Drupal 8's composer.json to specific package commits.