Test issue for #1862202: Objectify the language system to avoid spamming it with failing patches. Please ignore.

CommentFileSizeAuthor
#40 language-oo-2156425-39.patch297.84 KBplach
#40 language-oo-2156425-39.interdiff.txt608 bytesplach
#37 language-oo-2156425-37.patch297.89 KBplach
#37 language-oo-2156425-37.interdiff.txt1.93 KBplach
#35 language-oo-2156425-33.patch298.33 KBplach
#28 language-oo-2156425-28.patch295.16 KBplach
#28 language-oo-2156425-28.interdiff.txt23.47 KBplach
#27 language-oo-2156425-27.patch281.15 KBplach
#27 language-oo-2156425-27.interdiff.txt3.29 KBplach
#25 language-oo-2156425-25.patch280.55 KBplach
#25 language-oo-2156425-25.interdiff.txt21.53 KBplach
#24 language-oo-2156425-24.patch273.24 KBplach
#24 language-oo-2156425-24.interdiff.txt7.41 KBplach
#22 language-oo-2156425-22.patch272.7 KBplach
#22 language-oo-2156425-22.interdiff.txt1.75 KBplach
#19 language-oo-2156425-19.patch271.83 KBplach
#19 language-oo-2156425-19.interdiff.txt1.28 KBplach
#18 language-oo-2156425-18.patch272.9 KBplach
#18 language-oo-2156425-18.interdiff.txt17.91 KBplach
#16 language-oo-2156425-16.patch273.78 KBplach
#16 language-oo-2156425-16.interdiff.txt1.6 KBplach
#13 language-oo-2156425-13.patch271.87 KBplach
#13 language-oo-2156425-13.interdiff.txt13.43 KBplach
#11 language-oo-2156425-11.patch263.79 KBplach
#11 language-oo-2156425-11.interdiff.txt752 bytesplach
#6 language-oo-2156425-6.patch263.75 KBplach
#6 language-oo-2156425-6.interdiff.txt625 bytesplach
#4 language-oo-2156425-4.patch263.32 KBplach
#4 language-oo-2156425-4.interdiff.txt3.54 KBplach
#3 language-oo-2156425-3.patch262.33 KBplach
#3 language-oo-2156425-3.interdiff.txt15.33 KBplach
#1 language-oo-2156425-1.patch263.88 KBplach
#1 language-oo-2156425-1.interdiff.txt3.6 KBplach

Comments

plach’s picture

Status: Active » Needs review
StatusFileSize
new3.6 KB
new263.88 KB

Status: Needs review » Needs work

The last submitted patch, 1: language-oo-2156425-1.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new15.33 KB
new262.33 KB

Some cleanups

plach’s picture

StatusFileSize
new3.54 KB
new263.32 KB

Another fix

Status: Needs review » Needs work

The last submitted patch, 4: language-oo-2156425-4.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new625 bytes
new263.75 KB

The last submitted patch, 3: language-oo-2156425-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: language-oo-2156425-6.patch, failed testing.

plach’s picture

Status: Needs work » Needs review

6: language-oo-2156425-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: language-oo-2156425-6.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new752 bytes
new263.79 KB

Another easy fix.

Status: Needs review » Needs work

The last submitted patch, 11: language-oo-2156425-11.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new13.43 KB
new271.87 KB

Status: Needs review » Needs work

The last submitted patch, 13: language-oo-2156425-13.patch, failed testing.

The last submitted patch, 13: language-oo-2156425-13.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new1.6 KB
new273.78 KB
plach’s picture

plach’s picture

StatusFileSize
new17.91 KB
new272.9 KB

This fixes language services instantiation: now all the language-negotiation-related code is loaded only on multilingual sites.

plach’s picture

StatusFileSize
new1.28 KB
new271.83 KB

More clean-up. Let's see how it behaves.

The last submitted patch, 18: language-oo-2156425-18.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 19: language-oo-2156425-19.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new1.75 KB
new272.7 KB

Let's try this.

Status: Needs review » Needs work

The last submitted patch, 22: language-oo-2156425-22.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new7.41 KB
new273.24 KB

This should fix the last failures.

plach’s picture

StatusFileSize
new21.53 KB
new280.55 KB

And this cleans up language types. Once this is green we should be ready for review.

Status: Needs review » Needs work

The last submitted patch, 25: language-oo-2156425-25.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new3.29 KB
new281.15 KB

This should fix quite some failures.

plach’s picture

StatusFileSize
new23.47 KB
new295.16 KB

Moved language type info on the configurable LM and adjusted docs accordingly.

Status: Needs review » Needs work

The last submitted patch, 28: language-oo-2156425-28.patch, failed testing.

The last submitted patch, 27: language-oo-2156425-27.patch, failed testing.

plach’s picture

Status: Needs work » Needs review

28: language-oo-2156425-28.patch queued for re-testing.

No test failures here.

Status: Needs review » Needs work

The last submitted patch, 28: language-oo-2156425-28.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new25.78 KB
new298.33 KB

Moved the last stuff onto the language manager. Let's whether we can get rid of that failure.

plach’s picture

Status: Needs work » Needs review
plach’s picture

StatusFileSize
new298.33 KB

bot?

Status: Needs review » Needs work

The last submitted patch, 35: language-oo-2156425-33.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new1.93 KB
new297.89 KB

Finally green?

Status: Needs review » Needs work

The last submitted patch, 37: language-oo-2156425-37.patch, failed testing.

schnitzel’s picture

Status: Needs work » Needs review

37: language-oo-2156425-37.patch queued for re-testing.

plach’s picture

StatusFileSize
new608 bytes
new297.84 KB

#37 is actually green: the failure is unrelated and the test is passing on my machine. Posting a new patch with a potential improvement.

plach’s picture

Status: Needs review » Closed (fixed)

Hopefully we no longer need this.