FieldInstance::delete() removes the instance from EntityDisplays for all view modes, but only for the 'default' form mode

CommentFileSizeAuthor
#9 2041225-9.patch5.87 KBswentel
#9 interdiff.txt690 bytesswentel
#7 2041225-7.patch5.84 KBswentel
#7 interdiff.txt1.7 KBswentel
#5 2041225-5.patch5.92 KBswentel
#4 2041225-4-FAIL.patch2.43 KBswentel
#4 2041225-4-PASS.patch2.58 KBswentel
#4 interdiff.txt956 bytesswentel
#3 2041225-3.patch1.07 KBswentel

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

It would really helpful to have a helper to list modes per entity type

yched’s picture

yched commented
Issue tags: +Field API

tagging

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2041225-3.patch1.07 KB

This should do it. Will look for tests later, because it seems the entity display tests are actually not working properly.

swentel’s picture

swentel commented
StatusFileSize
new interdiff.txt956 bytes
new 2041225-4-PASS.patch2.58 KB
new 2041225-4-FAIL.patch2.43 KB

Some additional tests first for entity display because they were passing without knowing. I've added an explicit check to see whether the component exists or not. Interdiff is between fail and pass.

swentel’s picture

swentel commented
StatusFileSize
new 2041225-5.patch5.92 KB

And now with form display tests too. Note that I've added a form mode alter in entity_test module so I could test multiple form modes.

yched’s picture

yched commented

Thanks, looks correct. Just nitpicks on visual review:

+++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.phpundefined
@@ -255,19 +255,32 @@ public function testDeleteFieldInstance() {
+    // Check the components exists.

Minor: plural / singular mismatch (same in the other class)

+++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.phpundefined
@@ -119,4 +119,51 @@ public function testFieldComponent() {
+  }

Minor: missing empty line after last method.

swentel’s picture

swentel commented
StatusFileSize
new interdiff.txt1.7 KB
new 2041225-7.patch5.84 KB

Cleaned up.

Status: Needs review » Needs work

The last submitted patch, 2041225-7.patch, failed testing.

swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt690 bytes
new 2041225-9.patch5.87 KB

Ah, entity storage of course.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Thanks!
RTBC if green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 477cb6e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.