Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The image style upgrade path does not take into account the new image style name/label change that was backported to Drupal 7.23 from #606598: Human readable image-style names. The ImageUpgradePathTest does not use a filled database otherwise this would have been caught by automated tests.
A manual test can be done to reproduce this. Clone Drupal and checkout 7.23 or greater. Install with the standard install. Prepare site for upgrade, checkout 8.x, and run the install. There will be no image styles after upgrade when there were before the upgrade (see screenshots).
Proposed resolution
- Fix ImageUpgradePathTest
- Fix image_update_8000()
Remaining tasks
- Need patch
- Need tests
User interface changes
None
API changes
None
Related Issues
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | drupal-2062341-image-upgrade-path-test-only.patch | 1.94 KB | mradcliffe |
| drupal8-image-styles-after-upgrade.png | 26.36 KB | mradcliffe | |
| drupal7-image-styles-from-standard-install.png | 56.92 KB | mradcliffe | |
Comments
Comment #1
webchickGood find. Tagging as an upgrade path issue.
Comment #2
mradcliffeI might be incorrect about what introduced this bug, but it does exist.
Comment #3
mradcliffeDarnit.
Comment #4
mradcliffeHere's a start to changing ImageUpgradePathTest.php, but I am not sure if the thumbnail image style needs to be added as a custom style or not.
Not sending it to the bot.
Comment #5
David_Rothstein CreditAttribution: David_Rothstein commentedIs this the same issue as #2049465: Upgrade of image styles and effects broken?
Comment #6
tim.plunkettYes.