Panopoly Pages has missing dependencies

panopoly_core is needed for 'editor' role also, so that dependency should defiantly be added

Also need to clear a cache to get new panelizer permissions sometimes, patch attached

Any steps on how to reproduce this notice to test/review if it works on the latest code?

Well, it's fixed installing openatrium from install.php for several people, so that's one way to test.

Tried with latest code. On the Apps part during install I get a

Warning: Illegal string offset 'name' in apps_profile_apps_select_form() (line 101 of /var/www/------/sites/all/modules/contrib/apps/apps.profile.inc).

But looks like a different issue to me. Guess we can close this then!

Hm, panopoly pages has been covering up for a bug in defaultconfig I think, #2043307: 'features.defaultconfig.inc' file never added during install -- what is 'group' key for?, the features flush cache isn't needed. May update the patch here later.

Still actually getting this in OA2 even with this patch. So something else is going on. Will review the issue you linked for defaultconfig.

Hmm, I'm getting something slightly different than the original post I guess:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'rid' cannot be [error]
null: INSERT INTO {role_permission} (rid, permission, module) VALUES (:db_insert_placeholder_0,
:db_insert_placeholder_1, :db_insert_placeholder_2); Array
(
[:db_insert_placeholder_0] =>
[:db_insert_placeholder_1] => administer panelizer node panopoly_page breadcrumbs
[:db_insert_placeholder_2] => panelizer
)
in user_role_grant_permissions() (line 3076 of
/opt/clients/demo.openatrium.com/drupal/modules/user/user.module).

Added some debug statements and it looks like the code in panopoly_pages is running *before* the editor role in panopoly_core is created.

Looks like this was originally discussed here: #1837312: Troubles Implementing Default Permissions for Panelizer. Not sure what has changed and why panopoly_core is not running first now.

Wondering how this ever worked. Defaultconfig does it's magic in defaultconfig_modules_installed(). So it seems that the 'editor' role would not get created until after modules are enabled. Thus, the panopoly_pages_modules_enabled() running before the roles are created in defaultconfig.

Looks like this problem was resolved in #2043307: 'features.defaultconfig.inc' file never added during install -- what is 'group' key for? except this patch wasn't being applied to Open Atrium profile if you had an older version of git because it wasn't specifying git as the download method in the .make file. Fixed this and now it's getting past the panopoly_pages problem.

Moving this back to RTBC since panopoly_core is certainly a dependency.

#1837312: Troubles Implementing Default Permissions for Panelizer has a better solution for the cache clear. So all we really need here is the dependency.

New patch for just the dependency.

Adding the "sprint" tag - we're going to focus on this for the next release!

This has been committed to dev. Thanks.