Bundle info has been moved to a new hook hook_entity_bundle_info() and the menu_link entity type doesn't even need to explicitely declare any bundle at the moment.

CommentFileSizeAuthor
#1 1937384.patch572 bytesamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 1937384.patch572 bytes

And the patch.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Quick fix

Can't get any 'quicker' fix than this :)

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Sorry, x-post.

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 here and follow to issue #1966298: Introduce menu link bundles per menus

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -Quick fix

Where is this bundle defined then? I see user defines it with this hook, but no such hook for menu items? http://api.drupal.org/api/drupal/core%21includes%21entity.api.php/functi...

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Quick fix

It's provided by default in entity_get_bundles().

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Why do user module define it then?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Looks like this still needs discussion.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I've been responded to on IRC that people don't know either. However a module doing something relatively useless should not be a reason for this to do it too. One thing that user module does is it specifies a path for the account settings (as the bundle config path?) which is kind of odd. Although if that is useful for some UI interaction, then maybe menu module should do the same?

swentel’s picture

swentel commented

That path is used by Field UI so the 'Manage fields' and 'Manage Display' screens are placed correctly, so that's only usefull if your entity is fieldable.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.