Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is an to issue to catch various slightly off-topic or follow up sub-issues from the initiative to clean up core by removing t() from test assert messages.
Comment | File | Size | Author |
---|---|---|---|
#7 | 1797940-7-language-test-doc.patch | 841 bytes | dcam |
#1 | follow-up-1797940-1.patch | 1.43 KB | Lars Toomre |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedThis is follow up to review of #1797360: Remove t() from assertion messages in tests for the language module. LanguageUrlRewritingTest::checkURL() unexpectedly used two assert messages and the helper function in that test did not have any @param directives. The attached patch rectifies that.
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedHelps to set the right status!
Comment #3
Lars Toomre CreditAttribution: Lars Toomre commentedIn reading through many test files, I have also noticed inconsistent formatting as well as the use of t() in getInfo() functions. This is invariance with http://drupal.org/node/325974 and should be addressed once the bulk of the remove t() assert issues have been committed.
Comment #4
xjmRather than filing one followup, each unrelated change should have its own issue with a descriptive title. So the docs fix in #1 for example can be filed as an independent documentation issue, and removing
t()
fromgetInfo()
should be another separate issue, etc.Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedOK @xjm... I find it helpful to catch all for notes while doing the primary issue and then when have a little more time, to move them out to full follow up issues.
Comment #6
jhodgdonYes, each follow-up needs its own issue. Fixing the title for this one, and I've committed it to 8.x. Presumably this method also exists in 7.x somewhere and this needs to be ported?
Comment #7
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #8
jhodgdonThanks! I'll get this committed ASAP.
Comment #9
jhodgdonCommitted to 7.x -- thanks again!