Don't mind me, this is just a helper issue to run testbot without clobbering #1040790: _field_info_collate_fields() memory usage.

CommentFileSizeAuthor
#57 field-info-cache-1040790-196-D7.patch59.64 KByched
#56 field-info-cache-1040790-199-D7.patch59.18 KByched
#51 field-info-cache-1040790-196-D7.patch58.95 KByched
#47 field-info-cache-1040790-89-D7-4.patch46.83 KByched
#42 field-info-cache-1040790-89-D7-3.patch46.8 KByched
#40 field-info-cache-1040790-89-D7-2.patch46.84 KByched
#38 field-info-cache-1040790-89-D7.patch46.94 KByched
#36 field-info-dic.patch47.55 KByched
#35 field_info_cache-1305362-35.patch48.3 KByched
#34 field_info_cache-1305362-34.patch46.5 KByched
#33 field_info_cache-1305362-33.patch43.85 KByched
#31 field_info_cache-1305362-31.patch45.13 KByched
#29 field_info_cache-1305362-29.patch43.82 KByched
#27 field_info_cache-1305362-27.patch43.79 KByched
#26 field_info_cache-1305362-26.patch43.3 KByched
#24 field_info_cache-1305362-24.patch43.29 KByched
#20 field_info_cache-1305362-20.patch35.38 KByched
#19 field_info_cache-1305362-18.patch28.3 KByched
#17 field_info_cache-1305362-17.patch28.36 KByched
#15 field_info_cache-1305362-15.patch28.31 KByched
#13 field_info_cache-1305362-13.patch20.25 KByched
#11 field_info_cache-1305362-11.patch20.25 KByched
#9 field_info_cache-1305362-9.patch20.19 KByched
#7 field_info_cache-1305362-7.patch20.27 KByched
#5 field_info_cache-1305362-5.patch20.59 KByched
#3 field_info_cache-test-2.patch22.24 KByched
#1 field_info_cache-test.patch14.43 KByched
field_info_cache-test.patch0 bytesyched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_info_cache-test.patch14.43 KB

Gah.

Status: Needs review » Needs work

The last submitted patch, field_info_cache-test.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-test-2.patch22.24 KB

Really ?

Status: Needs review » Needs work

The last submitted patch, field_info_cache-test-2.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-5.patch20.59 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-5.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-7.patch20.27 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-7.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-9.patch20.19 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-9.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-11.patch20.25 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-11.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-13.patch20.25 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-13.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-15.patch28.31 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-15.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-17.patch28.36 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-17.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-18.patch28.3 KB

That one should be green.

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_info_cache-1305362-20.patch35.38 KB

Let's start refactoring, then.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Do we need tests for this?

yched’s picture

yched CreditAttribution: yched commented

The values returned by the various field_info_*() functions are used all over the place and are thus fairly extensively tested, as the # of fails / exceptions above show.

Tests for the caching behavior (static cache in the FieldInfoFieldCache properties and persistent cache in the cache_field table) could probably be useful though.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Fixed

Closing, back to the parent issue.

yched’s picture

yched CreditAttribution: yched commented
Status: Fixed » Needs review
FileSize
field_info_cache-1305362-24.patch43.29 KB

Crap, failures are back. Reopening the testing playground.

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-24.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-26.patch43.3 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
field_info_cache-1305362-27.patch43.79 KB

Refactoring.

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-27.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-29.patch43.82 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-29.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-31.patch45.13 KB

Status: Needs review » Needs work

The last submitted patch, field_info_cache-1305362-31.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_info_cache-1305362-33.patch43.85 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
field_info_cache-1305362-34.patch46.5 KB

More refactoring

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_info_cache-1305362-35.patch48.3 KB

Some more refactoring.

yched’s picture

yched CreditAttribution: yched commented
FileSize
field-info-dic.patch47.55 KB

Just trying out how the DIC plays with testbot right now.

Status: Needs review » Needs work

The last submitted patch, field-info-dic.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Version: 8.x-dev » 7.x-dev
Status: Needs work » Needs review
FileSize
field-info-cache-1040790-89-D7.patch46.94 KB

D7 backport ?

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-89-D7.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field-info-cache-1040790-89-D7-2.patch46.84 KB

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-89-D7-2.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field-info-cache-1040790-89-D7-3.patch46.8 KB

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-89-D7-3.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented

Is the testbot having some troubles tonight?

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented
Status: Needs work » Needs review

#42: field-info-cache-1040790-89-D7-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-89-D7-3.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field-info-cache-1040790-89-D7-4.patch46.83 KB
jthorson’s picture

jthorson CreditAttribution: jthorson commented

Looks like #45 either ran into or caused a cron issue on the testbot ... got an 'attempt to start review when already running', followed by an hour of 'attempting to re-run cron while it is already running' watchdog logs; suggesting that the cron process hung for the duration of that test.

yched’s picture

yched CreditAttribution: yched commented

@jthorson: sorry about that. #45 was an attempt at a D7 backport of #1040790: _field_info_collate_fields() memory usage. The problem was an improper conversion between D8 and D7's cache APIs. the patch contained cache_[get|set|clear_all]() calls with $bin = 'field' instead of 'cache_field'.

Not sure why that would lead to the effects you mentioned, but the patch is fixed now, won't happen again :-).

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Closed (fixed)

Let's close this one.

yched’s picture

yched CreditAttribution: yched commented
Status: Closed (fixed) » Needs review
FileSize
field-info-cache-1040790-196-D7.patch58.95 KB

Rebooting work on the D7 backport of #1040790: _field_info_collate_fields() memory usage. Let's see how this behaves.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy commented

(Just fyi, I don't use this particular patch on the production site anymore, as we've necessarily had to switch to a different solution outside the Entity/Field API for our profile system—we passed 600 entity types and 20,000 field instances, and Drupal was killing itself on cache rebuilds—with or without this patch).

I'll still help review the patch as best I can, of course, but I won't be able to test on such an outrageous installation :)

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-196-D7.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

#51: field-info-cache-1040790-196-D7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-196-D7.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field-info-cache-1040790-199-D7.patch59.18 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
field-info-cache-1040790-196-D7.patch59.64 KB

Status: Needs review » Needs work

The last submitted patch, field-info-cache-1040790-196-D7.patch, failed testing.