Class Style Filter

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Please create a README.txt that follows the guidelines for in-project documentation.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxcrobinson1549868git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hi

You have got two readme files ;-) (README.md and README.txt)

Coding style looks good. Here are a few other comments:

1. You can delete the whole master branch from your git repository, if you like, using the command git push origin :master. (Note the colon.)
2. You might consider reformatting your README.txt to something a little more standard.
3. class_style_filter.info should list Image module as a dependency. You should make clear in your documentation that WYSIWYG is a recommendation but not required.
4. The README.txt file could be a little clearer (detailed) on Configuration #2. #3 has a typo: "create one image styles". Also, you refer to "input formats", which are called "text formats" in Drupal 7.
5. I installed the module, and it didn't quite work out for me. It transformed an image tag for sites/all/files/test.jpg into one for http://d7.dev/sites/default/files/styles/thumbnail/public/tes/default/files/test.jpg. I don't know whether that's a bug in the module or a configuration error on my part. If it's a configuration error, there may be some deficiency in the README.

Please add your review to the issue summary as outlined in #1410826: [META] Review bonus.

manual review:

1. _class_style_filter_process(): as the filter settings are user provided input you should sanitize them before inserting them into the image tags. I think adiministering text filters is a site p0wning permission anyway, so this is not a blocking security issue.
2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, I took a look at your other contributions and they look fine, so I guess it is ok to give you the git vetted user role.

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Looks good, maybe remove that temporary (?) README.md file with "git rm" and add it to gitignore.

Thanks for your contribution and welcome to the community of project contributors on drupal.org!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process and for your help in the application queue! Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.