Removal of "Hidden" option in comment settings form may break programmatic form submissions

This one is related, but not really the same: #989452: Make comment settings form more usable

Rewords description of 'Hidden' comment setting, and removes code that removes the 'Hidden' option for nodes without existing comments.

#3: 1181750.patch queued for re-testing.

Cannot reproduce install failure on head or head + patch.

Attached patch is what you want. As this needs to be backported, no UI string changes here.

Sun's patch looks good. I wasn't aware of the #access property, but this will allow the UI to remain the same, while allowing for programmatic submission of a form with the comment setting set to 'Hidden'.

Yep, should always use #access rather than unsetting elements. Committed/pushed to 8.x, moving to 7.x for backport.

Ported to d7

Please leave the tag. It's the only way to distinguish between patches that have already been committed to 8.x, vs. new patches in the queue against 7.x (which are mis-placed 99% of the time).

Hm. it seems lke we could add a test for this, but since #access is unlikely to get un-done, I guess it can go in without.

Committed and pushed to 7.x. Thanks!

I think a test would be a good idea in this case. Moving to 8.x for a followup with a test.

Tests could be added to \Drupal\comment\Tests\CommentInterfaceTest the fixed code now lives in \Drupal\comment\Plugin\Field\FieldWidget\CommentWidget

There's issue to add tests #1847540: [META] Clean up comment module tests and decouple from node