Test with taxonomy translation + core menu + taxonomy menu. [#1237266]

Drupal ver. 7.7 other modules updated.

I.Taxonomy works fine
1. Localize. Terms are common for all languages, but their name and description may be localized.
2. Translate. Different terms will be allowed for each language and they can be translated.
both are working good.

II. MENU - WITH TAXONOMY MENU:

1.Localize:
During translation term from default got this error:
Notice: Trying to get property of non-object w i18n_string_translate_page_form_strings() (linia 130 z

/var/www/vhosts/tota.mojeserwery.eu/httpdocs/sites/all/modules/i18n/i18n_string/i18n_string.pages.inc).
Notice: Undefined index: w _filter_tips() (linia 1007 z /var/www/vhosts/tota.mojeserwery.eu/httpdocs/modules/filter/filter.module).
Notice: Trying to get property of non-object w _filter_tips() (linia 1011 z /var/www/vhosts/tota.mojeserwery.eu/httpdocs/modules/filter/filter.module).
Notice: Undefined index: w filter_list_format() (linia 674 z /var/www/vhosts/tota.mojeserwery.eu/httpdocs/modules/filter/filter.module).
Warning: Invalid argument supplied for foreach() w filter_list_format() (linia 674 z

/var/www/vhosts/tota.mojeserwery.eu/httpdocs/modules/filter/filter.module).
Notice: Trying to get property of non-object w _filter_tips() (linia 1012 z /var/www/vhosts/tota.mojeserwery.eu/httpdocs/modules/filter/filter.module).
but when I ignored translation was OK.

Menu items and content H1 title shows up but only with (default)source lang.

2.Translate:

a. In menu shows up only default language - translation is missed. Content H1 title shows up OK.

TIP: you have to create term with default language 1st and then translate term!!! If not there will be error:
Notice: Trying to get property of non-object w i18n_taxonomy_form_taxonomy_form_term_alter() (linia 751 z

/var/www/vhosts/tota.mojeserwery.eu/httpdocs/sites/all/modules/i18n/i18n_taxonomy/i18n_taxonomy.module).
and you get 2 different terms - not related to each other.

b. When term is not translated - 1 language choosen - menu and H1 title is OK.

c. When term is without choosen language - menu and H1 title is OK.

III. MENU - create normal in drupal core:
1. Localize:
Menu items shows up correct but content H1 title is showing up always from translated name of menu.

2. Translate:
a. Probably it's why at 2a.Translate Taxonomy menu don't how menu item. I can create menu item for taxonomy term in Default (not oryginal) language. But If

I'm trying create menu item for translated taxonomy term (or term created with not default language) I've got error: The path 'taxonomy/term/21' is either

invalid or you do not have access to it.
So thst's why I'm or others modules can't create menu item for translated taxonomy term!

Comments

Comment #1

totap commented 3 August 2011 at 07:54

Assigned:	Unassigned	» totap
Priority:	Normal	» Major

After few hours of testing I have some tips whitch help me (at least at this moment):

Tips are for 2,3 or more languages and about how to manage Taxonomy translation and Menu translation:

TAXONOMY - when use: Translate. Different terms will be allowed for each language and they can be translated.:

First you have to make you taxonomy terms in your DEFAULT language, then translate it but only 1st time you can use

"save and translate" so better use only "save"
*****
makeing taxonomy term in default language then "save and translate" is ok but next "save and translate" got error and makes not related taxonomy term.
Notice: Trying to get property of non-object w i18n_taxonomy_form_taxonomy_form_term_alter() (linia 751 z /var/www/vhosts/tota.mojeserwery.eu/httpdocs/sites/all/modules/i18n/i18n_taxonomy/i18n_taxonomy.module).
*****

MENU - when use: Translate and Localize. Menu items with language will allow translations. Menu items without language will be localized. :

It seems that you can use taxonomy term ONLY for specyfic language.
If you have 1Lang(term/1), 2Lang(term/2) and 3Lang(term/3) or more: in order to make menu for all this taxonomy terms you have to make menu link for term/1 in 1Lang when your user language is switched to 1Lang, you can translate menu for your taxonomy term term/2 and change path to it when you switch user language to 2Lang and so on...

I hope tha it can help someone and help developers to fix that bugs.

Comment #2

jose reyero commented 3 August 2011 at 09:32

Component:	Miscellaneous	» Compatibility
Category:	bug	» support
Priority:	Major	» Normal

So this is a compatibility issue with another contrib module. Patches will be welcomed though we won't count it as an i18n bug.

Comment #3

totap commented 3 August 2011 at 11:23

Hmm for me it's bug (check http://drupal.org/node/1237266#comment-4816732 ). At 1st time I tested it with taxonomy menu, but later I tested only Taxonomy translation, Menu translation (part of i18n module) and issues I've found for me are not incompatibility, but i18n module issues.
I'm not good at programing so can't make patch - only those "tips" :)

So please consider this once again. I do not want to be disruptive, just help as I can with that great module!

7.x-1.0-rc2

» 7.x-1.x-dev

I think it should work. Its time for i18n_taxonomy_menu ;) taxonomy_menu_handler() is the related function in taxonomy_menu.

Hooks

hook_taxonomy_menu_insert
hook_taxonomy_menu_update
hook_taxonomy_menu_delete
hook_taxonomy_menu_path

/**
 * HANDLING
 *
 * @param $op
 *  options are 'insert', 'update', 'delete' or path
 *
 * @param $node
 *  The node object.
 *
 * @param $args
 *  if $op == 'insert' then
 *    array with the following key/value pairs:
 *     'term' => term object,
 *     'menu_name' => menu that the item is set to apply to
 *  if $op == 'delete' then
 *    array(
 *      'tid' => TermID
 *      'mlid => Menu ID
 *    )
 *  if $op == 'update' then
 *     'term' => term object,
 *     'menu_name' => menu that the item is set to apply to
 *     'mlid' => Menu ID
 */
function taxonomy_menu_handler($op, $args = array(), $node = NULL, $item = array()) {
  // Get the initial $item
  if (empty($item)) {
    $item = _taxonomy_menu_create_item($args, $node);
  }

  // Let other modules make edits
  $hook = 'taxonomy_menu_' . $op;
  foreach (module_implements($hook) as $module) {
    $function = $module . '_' . $hook;
    $function($item);
  }

  // Update the menu and return the mlid if the remove element is not true
  if ($op != 'delete') {
    return _taxonomy_menu_save($item);
  }
}

Any takers?