The method get_join() of a views_handler class should always return something, otherwise PHP throws strict warnings. Patch attached.

CommentFileSizeAuthor
#7 views_many_to_one_helper-check_empty_join-1174130-7.patch1.09 KBpillarsdotnet
#8 views_many_to_one_helper-check_empty_join-1174130-8.patch1.09 KBpillarsdotnet
#6 views_many_to_one_helper-check_empty_join-1174130-6.patch839 bytespillarsdotnet
#1 views-handler-strict-get_join.patch302 bytesklausi
views-handler-strict-get_join.patch304 bytesklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
StatusFileSize
new views-handler-strict-get_join.patch302 bytes

Whoops, wrong patch, of course that line should not be commented out.

dawehner’s picture

dawehner
Primary language German
commented

I'm wondering when this bug came up. Perhaps some kind of underlying bug caused this.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

I agree, it's valid to return NULL if there is no join object. Whatever code is using get_join() might need to test to see that the returned join was valid. That's a better fix, IMO.

dawehner’s picture

dawehner
Primary language German
commented

So This issue seems to be closed won't fix?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

No, the code in views_many_to_one_helper->ensure_my_table() needs to check if an object or NULL was returned.

pillarsdotnet’s picture

pillarsdotnet commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Component: Miscellaneous » Code
Status: Needs work » Needs review
StatusFileSize
new views_many_to_one_helper-check_empty_join-1174130-6.patch839 bytes

Alternative patch, created against 6.x-3.x (which has the same problem)

pillarsdotnet’s picture

pillarsdotnet commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
StatusFileSize
new views_many_to_one_helper-check_empty_join-1174130-7.patch1.09 KB

Bah. Patched that in the wrong place. Corrected:

EDIT: Note that this is the 6.x-3.x version of the patch.

pillarsdotnet’s picture

pillarsdotnet commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
StatusFileSize
new views_many_to_one_helper-check_empty_join-1174130-8.patch1.09 KB

Here's the patch against the 7.x-3.x branch.

dawehner’s picture

dawehner
Primary language German
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Looks fine. Commited to both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.