In the list under the Revisions tab, when you click on a revision older than the current, you get one or more messages like this:
Notice: Undefined offset: 1 in DrupalDiffInline->process_chunk() (line 1284 of /Applications/drupal-7.0/sites/all/modules/diff/DiffEngine.php)..
Other than that the output seems ok

CommentFileSizeAuthor
#7 diff-1122206-7-notices-thrown-by-DiffEngine-process_chunk.d7.patch555 bytesalan d.
#2 undefined_offset.patch373 bytesbinford2k

Comments

bryancasler’s picture

bryancasler commented

Same problem

binford2k’s picture

binford2k commented
Status: Active » Needs work
StatusFileSize
new undefined_offset.patch373 bytes

I didn't spend the time to figure out the logic here, just band-aided the obvious bug.

realityloop’s picture

realityloop commented
Status: Needs work » Closed (cannot reproduce)

I'm unable to reproduce this on current dev release, please reopen if you can still reproduce and if you could add information about your environment too please php version etc it would be helpful.

alan d.’s picture

alan d. commented
Status: Closed (cannot reproduce) » Active

This was very simple to replicate on 2.0 and 2.x-dev.

  $a = "<p>asf</p><p>asdf</p><p>sdfg</p>";
  $b = "<p>asf</p><p>asdf</p><p>sdfgdsfg</p>";
  diff_get_inline($a, $b)

Bang the error appears.

Undefined offset: 0 in DrupalDiffInline->process_chunk() (line 1284 of sites\all\modules\diff\DiffEngine.php).

PS: Make sure that you are not suppressing warnings in your error settings.

bfdi533’s picture

bfdi533 commented

Same problem here. Bug is VERY obtrusive and need to get this fixed.

There is also a spot at line 1279 where the same patch needs to be applied. Once I patched the file in both places (1279, 1284) then I was able to get rid of the errors and display the inline diff properly.

alexh’s picture

alexh commented

Same problem and fix as in #5 for me. although output is still not ok, but this is probably due to other issues (date and field collection fields).

alan d.’s picture

alan d. commented
Version: 7.x-2.0-beta2 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new diff-1122206-7-notices-thrown-by-DiffEngine-process_chunk.d7.patch555 bytes
alan d.’s picture

alan d. commented

This should be resolved with the new branch, 7.x-3.0-alpha1 or 7.x-3.0-dev.

This is still alpha, so test carefully before use on a production site and report any issues back to the queues.

Leaving open to backport

mitchell’s picture

mitchell commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Marking this as fixed, as it is committed to the latest dev branch.

Please reopen this issue if this change introduced any bugs.

Follow-ups should be added in separate issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.