The available updates page lists a Drupal core update, but does not attempt to install it. We never noticed this before because before Drupal 6.17, all core updates were security updates, and PM was ignoring those.

CommentFileSizeAuthor
#4 plugin_manager_832464_4.patch728 bytesDrewMathers

Comments

jasondb’s picture

jasondb commented

Interesting, is this the cause of http://drupal.org/node/349283 and http://drupal.org/node/763158 ?

-Jason

DrewMathers’s picture

DrewMathers commented

Jason,

The answer is yes and no. In #349283: Update doesn't work, the issue that you and mainer reported is this issue. I think the original poster's problem is something else. #763158: plugin manager stopped working also appears unrelated.

As a workaround, you can unselect Drupal from the update list.

This is happening because PM detects the available update, but has no mechanism for updating core files.

DrewMathers’s picture

DrewMathers commented

Here is a fix:

In plugin_manager_admin.inc change line 533

From:    if ($project['status'] == UPDATE_NOT_CURRENT) {

To:           if (($project['status'] == UPDATE_NOT_CURRENT 
                 | $project['status'] == UPDATE_NOT_SECURE
                 | $project['status'] == UPDATE_NOT_SUPPORTED
                 )
                && $project['title'] != "Drupal" 
                && $project['title'] != "Drupal core"
              ) {

This also includes the fix for #515042: updates marked as security update do not appear in the update list

DrewMathers’s picture

DrewMathers commented
Version: 6.x-1.10 » 6.x-1.x-dev
Component: User interface » Code
Status: Active » Needs review
StatusFileSize
new plugin_manager_832464_4.patch728 bytes

Here is the above fix as a patch against 6.x-1.x-dev (2011-Feb-25)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Thanks for the work. It has been committed.

DrewMathers’s picture

DrewMathers commented

Joshua,

With this commit, the dev snapshot now has a lot of fixes for 6.x-1.10 bugs. Is it time for another release? I've been using the dev snapshot, and it seems pretty stable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.