When saving a field in Field UI, any of its formatter settings under Display Fields are lost.

CommentFileSizeAuthor
#13 553292-summary-fix-d7.patch1008 bytesandypost
#7 field_ui_wipe_display.patch3.51 KBquicksketch
#3 field_ui_wipe_display-553292-3.patch3.28 KByched

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: file system » field system

Grrr. I keep doing that!

yched’s picture

yched commented
Component: field system » field_ui.module
yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new field_ui_wipe_display-553292-3.patch3.28 KB

Patch. Kittens party time: also removes a TODO in this area, and useless explicit includes of field.crud.inc, that's automatically loaded anyway.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review

Oh, testing bot...

Status: Needs review » Needs work

The last submitted patch failed testing.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new field_ui_wipe_display.patch3.51 KB

Reroll to accommodate for changes caused by #367595: Translatable fields.

yched’s picture

yched commented

Thanks for the reroll, Nate.
Dare I bump to RTBC ? Fixing this will ease testing of Filefield / Imagefield patches.

yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Er, and actually doing it.

quicksketch’s picture

quicksketch
he/him
commented

Of course I actually tried this out also. It does indeed correct the saving of formatters when used in combination with the Image field patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Thanks, committed to HEAD.

Marking needs work because we need tests for this.

sun.core’s picture

sun.core commented
Priority: Critical » Normal

Tests don't qualify as critical.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 553292-summary-fix-d7.patch1008 bytes

Formatter settings button is hidden for field that has settings but summary returns empty string.

yched’s picture

yched commented
Status: Needs review » Closed (fixed)
Issue tags: -Needs tests

@andypost - the current behavior is intended.
Might be discussed, but does not belong to this thread. Care to open a separate issue ?

Resetting to closed rather than 'needs work for tests', because there's a separate issue for Field UI tests.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think we should discuss this at new issue #961412: Formatter settings button lost when summary is empty