modules with dependencies whose .info file sets required=TRUE cannot be enabled. [#490400]

I am working on #412518: Convert taxonomy_node_* related code to use field API + upgrade path, and this little bug appeared today.

The changes in this patch #224482: Please please please analyse this code and tell me where I am going wrong made all of core's field and widget types required. This means they don't appear at admin/build/modules. My work involved a new module that depends on the options module. When options module is required, the admin modules form indicates that "options" is missing. Saving the form disabled my module. I can't enable it again.

I know the workaround. Don't list required modules as dependencies. But is this the desired behavior?

Comment	File	Size	Author
#9	490400-8.patch	2.88 KB	jpmckinney
#7	490400-7.patch	2.34 KB	jpmckinney

Comments

Comment #1

Anonymous (not verified) commented 13 June 2009 at 02:23

My link is wrong. I meant to link the changes on this patch #372743: Body and teaser as fields.

Comment #2

Anonymous (not verified) commented 13 June 2009 at 02:25

Title:

modules which have dependencies that are also required cannot be enabled.

» modules with dependencies whose .info file sets required=TRUE cannot be enabled.

Comment #4

dave reid

he/him

English

Nebraska USA

commented 13 June 2009 at 18:40

So if your module is dependent on a required module, just don't put in as a requirement in the .info file. We don't list:

dependencies[] = user
dependencies[] = node

In all the core sub-modules.

Comment #5

Anonymous (not verified) commented 13 June 2009 at 20:43

Like I said: I know the workaround. However, if a contrib module depends on an optional core module that becomes required in a later version, the module may become disabled and could not be re-enabled even though all of the dependencies are enabled. The admin module form says that the module's dependency is missing when in fact it is enabled and required.

In Drupal 6, I can add a core required module as a dependency to another module, and that module can still be enabled and disabled.

Comment #6

webchick

she/they

English

Vancouver 🇨🇦

commented 19 January 2010 at 03:03

Issue tags:

+DrupalWTF

I ran into this today, and it was a complete WTF:

The more I think about it, the more I really don't like hiding required modules from this page anyway, though. It really obfuscates how Drupal works. I'm wondering if we should fix this by reverting #293223: Roll back "Hide required core modules".

On the other hand, this likely fails when requiring hidden = TRUE modules as well, which we /do/ want hidden, even when they do exist. So I think there's still a bug here to sniff out.

Comment #7

jpmckinney commented 15 April 2010 at 18:49

Status	File	Size
new	490400-7.patch	2.34 KB

This patch fixes the bug in the title of this issue. It will also make it such that modules with "required = TRUE" will not appear in the "Requires: !module-list" list.