Able to display 'native language' text in Node translation:language field

Thats a valid feature request :)

I did not tested the patch yet, but from the api it looks fine, so i need someone who tests this.

You should better learn how to apply patches... its an important skill on drupal land.

Its documented good on http://drupal.org/node/60179

In the field at the bottom. I guess i should test this patch :)

Hi,

I can confirm that the patch doesn't add an extra option to let the language names appear in the native language.

I corrected

parent;;option_definition()

but that didn't do the trick.

So this patch, patches now also the other field handler.

I patched it successfully, but when I try to view or administer a view I get

Fatal error: require_once() [function.require]: Failed opening required './sites/all/modules/views/modules/translation/views_handler_field_node_language.inc' (include_path='.;C:\php5\pear') in C:\wamp\www\mysite\sites\all\modules\views\includes\handlers.inc on line 77

but it's probably php-related

Take sure that the file /sites/all/modules/views/modules/translation/views_handler_field_node_language.inc is readable by your apache.

Hi,
I couldn't really fix my fatal error after patching. How can I see if Apache has access on the file? For now, I just copied the contents of the patched file into the original file, and that works. Don't know what that should tell me. Could it have something to do with Unix/Win line endings? I am running a Windows machine here.

However!

I completed your patch, dereine (oh now I get it, it means The One, since you are from Germany ;).

I just added a $this-> to options in line 26, and tweaked the description a little bit, since it was a bit messy. Same changes for both handlers; I split the patches again (because I thought it had something to do with the fatal).
Should work now!

Thx for the patch dereine. I would very much appreciate it if you could start on http://drupal.org/node/565530 (Translation Link Field). I'd be there to review the patch ofc!

I completed your patch, dereine (oh now I get it, it means The One, since you are from Germany ;).

No it means "someone".

#13

glad that it works now! What about: "If enabled, the native name of the language will be displayed"?

I don't know what you mean exactly. Could you elaborate, or make a suggestion on the wording?

And dereine, does the patch need work, or is it ready to comit?

I don't know the state of the patch. There are too many to know every patch.

It looks like the patch works and just needs to be updated for wording. Would someone like to figure out the best wording to match core's use and reroll?

Still waiting on #19.

  $form['native'] = array('#type' => 'textfield',
    '#title' => t('Native language name'),
    '#maxlength' => 64,
    '#default_value' => @$language->native,
    '#required' => TRUE,
    '#description' => t('Name of the language in the language being added.'),
  );

I don't like the description here. #779436-15: Able to display 'native language' text in Node translation:language field looks better for me, together with #779436-16: Able to display 'native language' text in Node translation:language field
"If enabled, the native name of a language will be displayed"

Ok, let's go with the wording in #21. Only, "a language" should be "the language".

So "If enabled, the native name of the language will be displayed."

Rerole with that and mark RTBC.

Ok, all good things come to an end. Wait, that's not the right phrase ...
Anyway, I made 2 new patches with the changes using diff.
If you need git, I see what I can do (git noob here).

I committed this to 2.x-dev -- I tried to cherry-pick it but it failed the merge.

Here's the commit hash: 5e66dd1

git cherry-pick is indeed a really great tool.

Ported the commit to 6.x-3.x and 7.x-3.x