My apologies. In #569362: Document $attributes, $title_attributes, and $content_attributes template variables, I don't know why, but I missed thinking through that $content_attributes would also be needed. Patch coming.

CommentFileSizeAuthor
#12 608036_user_profile_attr_12.patch1.95 KBscor
#10 608036_user_profile_attr_10.patch1.94 KBscor
#9 608036_user_profile_attr_9.patch1.82 KBscor
#1 drupal-theme-content_attributes-608036-1.patch5.96 KBeffulgentsia

Comments

effulgentsia’s picture

effulgentsia commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Active
Issue tags: -RDF
StatusFileSize
new drupal-theme-content_attributes-608036-1.patch5.96 KB

It's really a no-brainer and I don't know how I missed it in the earlier issue. All the tpl file already have a div for the content, and that's the div that should be used for RDF attributes that describe the content of the entity as opposed to the entire entity. The current RDF patch gets around it by putting an extra div around the content where it needs it, but this way, we can remove redundant divs.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Reviewed & tested by the community

Makes perfectly sense.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Normal » Critical
Issue tags: +RDF
moshe weitzman’s picture

moshe weitzman commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community
Issue tags: +RDF

+1 from me too

scor’s picture

scor commented
Priority: Critical » Normal

I confirm this solves the intended issue. already committed as part of #493030: RDF #1: core RDF module

EDIT: I meant included for now in the patch #493030: RDF #1: core RDF module until this is committed.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Normal » Critical

Slight confusion about the term "committed", I guess.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Looks good to me, committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

scor’s picture

scor commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 608036_user_profile_attr_9.patch1.82 KB

The patch #1 didn't cover user-profile.tpl.php. Tests included.

scor’s picture

scor commented
StatusFileSize
new 608036_user_profile_attr_10.patch1.94 KB

fix documentation

sun’s picture

sun
Primary language German
Location Karlsruhe
commented 
+++ modules/rdf/rdf.test
@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+  function testAttributesInMarkup4() {

4?

+++ modules/rdf/rdf.test
@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+    $this->assertTrue(!empty($user_profile_about), t('RDFa markup found on user profile page'));
+
+  }

Please remove this blank line.

Powered by Dreditor.

scor’s picture

scor commented
StatusFileSize
new 608036_user_profile_attr_12.patch1.95 KB

addressed sun's review.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay! The first RDF patch I understand! ;)

Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -RDF

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +RDF

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.