Users with administration permissions should always be able to edit the meta tags, independently from the fact they are enabled to appear in edit forms, or if they are enabled to appear in the HTML output.
Nodewords does the opposite of what is done from Drupal core modules, which (in example) allow an administrator user to create a node revision even when the normal users are not allowed.

CommentFileSizeAuthor
#12 nodewords_0961B010.patch2.79 KBavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Fixed

The code has been changed. and committed in CVS (http://drupal.org/cvs?commit=299452).

prolific_one’s picture

prolific_one commented

But also, if an admin doesnt want the dozen different meta tag types listed on the edit page then there should be an option for them to only have the tags that they want displayed. This option could be displayed on the meta tag admin page, simply with a check box that says "admins with permissions to meta tags will view all meta tags and be able to edit all meta tags." Then they still have the option to leave it the old way...

Because now I have a dozen meta tag types cluttering my meta tag tab on the edit page when I only edit two.

machinez’s picture

machinez commented
Title: Users with administration permissions should always be able to edit the meta tags content » Update.php hung on Nodewords module upgrade
Version: 6.x-1.x-dev » 6.x-1.7
Priority: Normal » Critical

Just upgraded Nodewords. update.php is stuck at 49% for over 15 mins so far. mysqld and php-cgi seem to be using a lot of cpu. I have about 500 nodes on my Drupal instance

machinez’s picture

machinez commented

Hit back on the browser. Ran update again with 6157 instead of 6156. Seem to have worked. Processes back to normal. Will advise if there are any oddities.

frosty29’s picture

frosty29 commented

@machinez - but are your nodewords right? I ran the second update after reading your comments but my nodewords are all fried. View source and check?

chrisada’s picture

chrisada commented
Status: Fixed » Active

I am upgrading from 6.x-1.5 to 6.x-1.7 and update.php got stuck at 41% for a long time. At the end of it I got this error message

An HTTP error 0 occurred. http://example.com/update.php?id=33&op=do

I've tried this twice.

I'm not thinking of just uninstalling the module and re-install with the latest version, but have not gone through with it yet.

machinez’s picture

machinez commented

@Frosty. I checked about ten nodes manually. They seem ok. http://NumisEX.com/

Source: http://numisex.com/blog/1/2009/8/israel-may-raise-key-rate-monday-inflat...
meta name="description" content="israel inflation raise rates stimulus economy"

Source: http://numisex.com/blog/1/2009/8/options-gold-and-silver-etfs
meta name="description" content="option greeks gold siver income gld slv"

machinez’s picture

machinez commented

I see a lot of people are having this issue. http://drupal.org/node/654206
Reverting even though a sampling of nodes look ok.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Update.php hung on Nodewords module upgrade » Users with administration permissions should always be able to edit the meta tags content
Version: 6.x-1.7 » 6.x-1.x-dev
Category: bug » task
Priority: Critical » Normal
Status: Active » Fixed

@prolific_one: As I reported, users with administrator permissions do see more form fields than authenticate users; the user with permission to administer nodes see the form field to create a new revision, even if the option to create new revisions has not been enabled in the content type edit form.

@machinez: Please don't hijack the reports; this report is about a completely different thing.

gbernier’s picture

gbernier commented

I found it annoying to have an administer meta tags permission and when I turned it off I still saw all the meta tags. The messaging really wasn't clear, looking in code saw on line 91 of nodewords.module 'page:permissions:see_all_tags' => 'administer nodes', I've got users who need to administer nodes but I don't want everyone to be bombarded with all the new elements. I've updated line 91 to be 'page:permissions:see_all_tags' => 'administer meta tags', as it seems more logical only people who can adminster the meta tags can actually see all the meta tags.

Wanted to post this incase others ran into this issue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@gbernier: In Drupal, the users with permission to administer nodes are able to edit everything of a node.
Anyway, looking at the code of path.module, the form field to edit the path alias is visible to who has the permission to create an alias; maybe I should just limit the code to shows all the form fields to who has the permission to administer meta tags.

In any case, it is contrary of what is done in Drupal that users with administration permissions see the same form fields as the normal users; in this case, it is to define which administration permission must be considered.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new nodewords_0961B010.patch2.79 KB

The attached patch is the patch that changes the code as for the last commit I did. It changes the permission to see all the meta tags edit fields to administer meta tags.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 6.x-1.x-dev »
Status: Fixed » Patch (to be ported)
gbernier’s picture

gbernier commented

Thanks for creating the patch kiamlaluno

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Patch (to be ported) » Fixed

The code has been changed in the branch 6.x-3 as well.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Thanks for the patch kiam.

The administer nodes permision is already overloaded as it is. So adding these perms onto 'administer meta tags' is a good move.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.