Closed (fixed)
Project:
Drupal Terminal
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
17 Nov 2009 at 20:43 UTC
Updated:
13 Dec 2009 at 08:50 UTC
Jump to comment: Most recent file
Hi - just wondering whether there has been any progress on the 6.x that hasn't been reported back on here
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | cleanup.patch | 4.29 KB | robloach |
| #7 | terminalpimpage.patch | 15.32 KB | robloach |
| #4 | terminalpimpage.patch | 13.52 KB | robloach |
| #3 | terminalpimpage.patch | 12.68 KB | robloach |
Comments
Comment #1
snufkin commentedNot really, I haven't had the time. I am planning to go along the line of the drush integration, but if you have features to suggest, i am happy to hear it.
Comment #2
robloachI have a pretty awesome patch coming up.... I'll throw it up here tomorrow.
Comment #3
robloachThis patch ports the module to Drupal 6, as well as cleans up the code a bit.
New Features
hook_terminalto expose functions to the terminal rather thentermanal_$commandas well as documentation in terminal.api.phpComment #4
robloachComment #5
snufkin commentedLooks great. A note: the terminal_history table was used for recording the command history so we can provide a working command history just like on in a shell. Temporary storage could be a cookie, or js variable, but if we store it in the db then its retained after the former arent (losing cookies, revisiting page).
Comment #6
robloachAh, I see. So we could replicate the "history" bash command :-) .
Comment #7
robloachComment #8
snufkin commentedCommitted with a few cosmetic changes to the patch (now passes coder review, altered the hook_update_N to just add the field etc).
Comment #9
robloachNice, great job :-) .....
You're probably missing:
.... in the update function too ;-) . The log tracks the time when the command was executed too.
What is the next issue to work on? Yes/No confirmations? I was also thinking we should add an "access callback" and "access arguments" to each function as well, so that each function could have granular control over who can call it.
Comment #10
snufkin commentedAh damn i should've thought about that field too...
I think we should be looking at implementing the dialogue option to get the Drush integration possible first. We can look at the granular access control later on when we are getting more functionality.
Can you take a look at the provided JS library? I have the feeling we need to fork it, I don't really see any other way to extend it to be able to handle this.
Comment #11
robloachThis patch includes the things missing from your last commit....
... As for confirmations, I think that should and could be handled on the server side. What we'd need is a state machine to manage the Terminal's current state. I think that discussion should be over here: #641970: Handle y/n dialogues :-) .
Comment #12
snufkin commentedCommitted: http://drupal.org/cvs?commit=295204 and http://drupal.org/cvs?commit=295202