Problem/Motivation

The SEO tools recipe adds the Full HTML format, which was necessary initially because we didn't have a great way to add content to the dashboard. But we should generally be adding links to dashboards via menus, now that we have established that as the way forward.

We have decided not to ship with a Full HTML format, so we need to remove this from the recipe. And since currently, the SEO dashboard only uses HTML content, we should remove it while we resolve the dashboard scope in general.

Issue fork drupal_cms-3488285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

thejimbirch’s picture

thejimbirch commented

Would this be resolved by creating our own separate recipe for our desired text format, so that other recipes could apply it as needed?

Yes. Since the Drupal CMS starter recipe hasn't defined a text format, the tracks have had to require their own dependent formats. If it were to be defined that all recipes must use recipe x text format, we could have consistency.

pameeela’s picture

pameeela commented

I think as a rule, dashboards shouldn't create HTML content. For one thing, this means the links are hard coded and will display to all users regardless of whether they have permission to access the page. We also won't be able to style them properly.

In #3481417: Define how wireframes links block on the right should be created we decided to use menus for the task links in the dashboard design, which solves both the access and styling problem.

Perhaps we can merge this with #3476802: User Experience (UX) Review of the SEO Dashboard which is closely related.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

I think as a rule, dashboards shouldn't create HTML content.

Fully agreed with this. The use of HTML has always felt like a kludge and it needs to be replaced sooner rather than later.

pameeela’s picture

pameeela commented
Title: SEO tools should not add Full HTML text format » SEO tools dashboard should not add HTML content
Issue summary: View changes

In light of #3476802: User Experience (UX) Review of the SEO Dashboard where I proposed that we merge the additional shortcuts into the main dashboard, should we remove the SEO dashboard in the meantime while we work out the details?

pameeela opened merge request !232

pameeela’s picture

pameeela commented
Status: Active » Needs review
pameeela’s picture

pameeela commented

Apologies if this feels hasty but I am antsy to get rid of Full HTML :) We can add this back in once we have a clear plan for it where we can't add the necessary elements to the main dashboard (which is pretty sparse anyway!).

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Reviewed & tested by the community

Added first approval.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: SEO tools dashboard should not add HTML content » Remove the SEO dashboard for now

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Sad to see it go but the removal makes sense until Dashboard is more capable. Merged into 0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.