Overview

Attempt to simplify #3467954: META: Evolve XB UI's data model to allow non-SDC components' inputs, DynamicPropSource support, etc. by ensuring that, on the front end, we always get a component's name from the component list data and not from the instance of the component's model data. This means that props called name should no longer be an issue.

Proposed resolution

To express this in pseudo code, instead of

model[selectedComponentUUID].name

we should be doing something like

allComponentsList[selectedComponentId].name

User interface changes

The UI visibly shouldn't change, but everywhere we get a component's name should be changed:

  1. Component preview overlay
  2. When dragging into the preview and hovering over a slot it should show the slot's name
  3. Layers panel (actually this has changed, it previously said "Slot" for each slot, but will now show the slot name.
  4. Context menu when right-clicking a component
  5. Save as section dialog
  6. The little blue rectangle you see when dragging a component (the dragImage)
CommentFileSizeAuthor
#5 Slot_names.png11.25 KBjessebaker
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jessebaker created an issue. See original summary.

jessebaker’s picture

Issue summary: View changes

longwave made their first commit to this issue’s fork.

jessebaker’s picture

Assigned: jessebaker » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new11.25 KB
wim leers’s picture

Assigned: Unassigned » jessebaker
Category: Feature request » Task
Status: Needs review » Reviewed & tested by the community
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
Related issues: +#3467954: META: Evolve XB UI's data model to allow non-SDC components' inputs, DynamicPropSource support, etc.

Only 2 nitpicky questions, up to @jessebaker to decide how to handle those 😊

wim leers’s picture

Assigned: jessebaker » wim leers
Status: Reviewed & tested by the community » Needs work

Even though this was RTBC before #3478565: Add Entity Update controller, un-RTBC'ing this because that other issue is an order of magnitude more complex, and moves some code around that this MR would have made obsolete. This MR should now remove the code that that moved.

Will do the reroll here! 🤓

wim leers’s picture

Assigned: wim leers » jessebaker
Status: Needs work » Reviewed & tested by the community
wim leers’s picture

  • jessebaker committed 7612693f on 0.x
    Issue #3487773 by jessebaker, longwave, wim leers: Get component name...
jessebaker’s picture

Assigned: jessebaker » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -blocker
wim leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.