At the moment tour.module.css has no css rule for if an element within a tip dialog modal gets into focus. the focus in use is the default focus style of the browser. for one that style is not in line with the default focus style in claro (is gin using the same css variables btw? ) and the default browser focus style in my case in safari has a too low color contrast (#93B4FB/#FFFFFF -> 2.1:1, but 3:1 would be required).
admin/appearanceAdd outline: var(--focus-outline) and box-shadow: var(--focus-box-shadow) for the previous and next button as well as the close button of a tour dialog modal.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | touchtarget.jpg | 37.19 KB | rkoller |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
smustgrave commentedComment #3
smustgrave commentedComment #5
smustgrave commentedComment #6
pooja_sharma commentedI have verified changes has been applied as mentioned in IS & attached the screenshots as well moving to RTBC
Comment #7
pooja_sharma commentedComment #8
rkollerlooks good, thank you! while testing i've noticed that there is one related detail i forgot. up to you if it should be fixed within this issue or shall we open a new one? if you take a look at the cancel button the target size is too small. the icon itself has 20px by 20 px in the css. for SC2.5.8 the minimum is at 24x24 pixels. for 2.5.5.(AAA) it would require at least 44x44 pixels.
Comment #10
smustgrave commented