Meeting will happen in #d10readiness on drupal.slack.com.
Hello and welcome to this Drupal 10 readiness meeting!
This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3307843`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.| Björn Brala (bbrala) | Björn, doing things everywhere. |
| lauriii | :wave: |
| xjm | :wave: |
| longwave | Dave, UK |
| quietone | Hi |
| Ilcho Vuchkov (vuil) | Ilcho Vuchkov BG :flag-bg: |
| Spokje | Frank, NL, unfashionably late. |
| amey mudras | :wave: |
| Vighnesh Sadagopal | Vighneshh, india |
| Kristen Pol (she/her) | Kristen, California, catching up |
| Björn Brala (bbrala) | There are some issues with removed core modules. Fascade is not allowing them to be installed on core <9.4 when through dependencies in contrib. @mixologic is working on a fix. But still good to mention I think. |
| Björn Brala (bbrala) | There will probably be another porting event during Prague it seems. Linking for visibility https://drupal.slack.com/archives/C03FH8GTB1A/p1663003014194619?thread_t... |
| xjm | QuickEdit regressions that need fixing |
| xjm | PHP 8.2 compatibility |
| xjm | Manual testing of the theme upgrade paths for Classy-dependent themes |
| xjm | Also looks like #3269082: Remove HTML5 details collapse polyfill NR has a fail (edited) |
| xjm | And #3308821: Update stylelint-config-standard to 28.0.0 NR also |
| Gábor Hojtsy (he/him) | More info on timing at https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... |
| Gábor Hojtsy (he/him) | Raised by @Björn Brala (bbrala) |
| Björn Brala (bbrala) | It will be fixed. Just important to know. |
| Spokje | So what's the current situation? Do we still need to file issues for each contrib module declaring a dependency on a "removed-in-d10"-extension with a version constraint on that dependency, or will/is that (be) fixed with the "magic" that @mixologic was talking about? |
| Björn Brala (bbrala) | Mixologic is fixing the requirement <9.4 |
| Björn Brala (bbrala) | In regards to specific weird version requirements, there are no other examples in contrib that are breaking, see other thread. |
| Björn Brala (bbrala) | Yesterday their network went awol, so he was suddenly preoccupied. |
| mixologic | Im working on testing the “magic” I made. Some things cant be undone once they’re in the wild, so gotta make sure this doesnt have unintended consequences. |
| Björn Brala (bbrala) | Great to hear 🙂 If we want an external review, I could help (if the endpoint is publish-ish) |
| mixologic | yes, theres going to be another endpoint on our staging server. Been a long while since we’ve wired anything up to it, so I have to make sure its mostly up to date |
| Björn Brala (bbrala) | If you want I can probably do some testing. Installing different kind of modules on different versions of Drupal. (moved modules, normal modules, themes, old versions etc) |
| Björn Brala (bbrala) | If you have a testscript you are using that would be great ofcourse, but i'd not be suprised if you dont 🙂 |
| mixologic | Definitely dont have a test script. |
| Björn Brala (bbrala) | No worries, i'd probably log my tests |
| Björn Brala (bbrala) | (did some pm-ing) |
| mixologic | Aight. so for drupal 9.3 and back, because we already have the ‘replace’ section, ‘drupal/hal’ is satisfied. |
| Björn Brala (bbrala) | :smile: |
| mixologic | first test is run composer-create project drupal/recommended-project:~9.3.0 and then composer require drupal/better_normalizers:@beta |
| Björn Brala (bbrala) | Give me the endpoint and i'll write a quick test script that compares the results of production and staging. 🙂 |
| Björn Brala (bbrala) | yeah i'd do a few versions of drupal probably. |
| mixologic | well, right now Im trying to get the ‘broken’ scenario |
| Björn Brala (bbrala) | you need to require a specific beta then |
| Björn Brala (bbrala) | beta5 fixed the issue in the module |
| Björn Brala (bbrala) | beta4 should be broken |
| Björn Brala (bbrala) | i think |
| Björn Brala (bbrala) | Anyways, im leaving for home, ill check in after getting the kids in bed and doing some chores :stuck_out_tongue: |
| mixologic | Okay, well Im trying to figure out what’s still actually broken |
| Björn Brala (bbrala) | Ah |
| mixologic | < 9.3 the replace should work, and if we updated all the contribs to have 9.4 compat versions, then those seem to work too |
| mixologic | I.e. Im not entirely sure we need this now |
| Björn Brala (bbrala) | :sweat_smile: |
| Björn Brala (bbrala) | Not sure about that |
| Björn Brala (bbrala) | But need to leave unfortunately sorry |
| mixologic | sure |
| Spokje | So core 9.3.0 with composer require drupal/better_normalizers:1.0-beta4 fails on the version constraint in the info.yml(https://git.drupalcode.org/project/better_normalizers/-/blob/8.x-1.0-bet...) with a friendly./composer.json has been updated Running composer update drupal/better_normalizers Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 Installation failed, reverting ./composer.json and ./composer.lock to their original content.Unsure if you're magic is supposed to fix that specific issue: We need it.If it is for fixing the general core 9.4.x not allowing contrib incarnations of deleted-core-extensions: Those are all on >=9.4 by now and no more magic seems to be needed. |
| Björn Brala (bbrala) | Thank you for the repro there spokje |
| mixologic | Diesnt beta 5 of bettter normalizers fix that? |
| Spokje | Yep, but it also shows that currently, the facade doesn't work (well) with version constraintsin the info.yml for contrib incarnations of deleted-core-extensions .Still unsure what your magic is suppose to fix, if it's the above or the general 9.4 issue. If the latter, that's already handled by having all those contrib incarnations on allowing core >=9.4 |
| mixologic | So, the facade is not now or in the future going to be able to handle contrib modules specifying versioned constraints on core modules that get removed in the future. |
| mixologic | The hack I was planning on putting in place would have only half solved that issue, by making it appear as though core provides the dependency, but as soon as somebody using that contrib upgrades to drupal 9.5, everything breaks. |
| mixologic | The only way we can definitively solve that problem is change the policy on how we remove a core module, such that it gets a whole chain of matching releases and version numbers as if it never lived in core in the first place. |
| mixologic | (i.e. make it so the extracted contrib versions are all 9.5.0 etc) |
| Björn Brala (bbrala) | Yeah, that means a bit more complicated subtree split I guess |
| Björn Brala (bbrala) | And a ton of release nodes also? |
| Gábor Hojtsy (he/him) | Raised by @xjm |
| xjm | So there are several of these, mostly due to stuff from core landing after we already removed QE |
| xjm | #3308697: Use FloatingUI instead of PopperJS |
| xjm | The scope of that issue is wrong |
| xjm | It should be to convert to FLoating UI |
| xjm | #3304909: Skip contrib Quick Edit's Settings Tray integration test until Settings Tray provides an API to improve integration in #3308867 |
| xjm | #3309243: New test failures on D10: `UnknownExtensionException: Unknown themes: classy` |
| xjm | #3309242: New test failure: CKEditor5QuickEditLibraryTest::testQuickeditTemporaryWorkaround() |
| xjm | Plus #3304909: Skip contrib Quick Edit's Settings Tray integration test until Settings Tray provides an API to improve integration in #3308867 is still outstanding |
| Björn Brala (bbrala) | Working hard @wimleers (he/him)? Was going through these issues and you're touching them all :stuck_out_tongue_winking_eye: |
| Kristen Pol (she/her) | Summary of status of the issues above:3308697 - Active3304909 - Fixed3309243 - Fixed3309242 - Fixed |
| Gábor Hojtsy (he/him) | Raised by @xjm |
| xjm | #2531564: Fix leaky and brittle container serialization solution is the most urgent and is close to RTBC |
| xjm | Then there's #3298731: Using ConstraintViolation::$arrayPropertyPath bugs on PHP 8.2 |
| Kristen Pol (she/her) | Summary of status of above issues:2531564 - Fixed3274474 - Fixed / Patch to be ported3298731 - Needs review |
| Gábor Hojtsy (he/him) | @lauriii has been looking for folks in this area 🙂 |
| xjm | To my knowledge this wasn't done yet. #3308518: [Meta] Tasks to remove Classy theme from core and move to contrib Since theme don't work the same as modules, we may need to modify or add to the upgrade instructions |
| xjm | I recommend testing with a contrib theme extending Classy. (edited) |
| xjm | This is actually pretty critical since the instructions are sparse and to my knowledge we haven't tried it at all |
| xjm | Plus we need to modify our manual testing script from what modules have |
| Gábor Hojtsy (he/him) | @lauriii was asking at https://drupal.slack.com/archives/C0D5GJZ8B/p1662708669054499 |
| Björn Brala (bbrala) | Hmm |
| xjm | I would just grep contrib, although the fact that we don't know what a random theme is supposed to look like adds work if a maintainer doesn't volunteer |
| Björn Brala (bbrala) | Are there in contib though? How would they be referenced? I tried searching for dependencies in contrib, but the search engine might not index themes perhaps. |
| Björn Brala (bbrala) | I wouldn't mind thinking about this and doing (and documenting) that testing |
| xjm | https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs... |
| xjm | There are 25 pages of themes that extend Classy there, including many that already have been upgraded for D9 🙂 (edited) |
| Björn Brala (bbrala) | tried theme: classy and got no results o_O but was in the other indexer thing. |
| Björn Brala (bbrala) | Ok, ill promise to do a testrun like i did for the modules but for a theme. |
| lauriii | To my knowledge this wasn’t done yet.I did do the manual testing using Garland |
| lauriii | Wouldn’t hurt to have someone else test with their theme too but I think technically that has been done |
| xjm | @lauriii Is there an issue where the testing is documented? It isn't linked in the meta |
| lauriii | #3110137: Remove Classy from core#comment-14687222 |
| lauriii | Does it need a separate issue? |
| xjm | @lauriii Aha -- it doesn't need a separate issue per se; just that's how we've been doing them so far to document and reproduce all the variations of ways people might install and upgrade it |
| xjm | @lauriii When you said you tested it with Garland, that doesn't indicate if you tested updating from D9 to D10 etc. See #3303420: Manually test aggregator module removal#comment-14650181 for an example of what we've done so far. |
| xjm | @lauriii We also haven't tested what core does if a theme is missing AFAIK, unless I missed it in the Bartik and Seven deprecations. But we also need ot know how that is surfaced for base themes and if it differs. (edited) |
| lauriii | I tested it using the steps from comment #41 on the issue. I updated from 9.5 to 10.0 as I tested it |
| lauriii | I think there’s a WSOD if the base theme of the active theme is missing |
| xjm | OK, the white screen might be worth filing an issue for. With modules there is a clean error message on upgrade. |
| lauriii | I’m not sure we could handle missing active theme gracefully. If it’s not the active theme, it’s handled gracefully |
| xjm | Not even an error on update.php? |
| xjm | Guess it depends on what the maintenance theme is |
| lauriii | I think update.php would not WSOD |
| xjm | Yeah with modules you get an error, although drush circumvents it. There is also a message on the status report. |
| xjm | Displaying the content in stark would probably be better than a white screen, although I don't know how much work that would be if core doesn't do it already. There is also the added complication that block placements are associated with the theme and so blocks will be missing that might make it hard to navigate even if we did have Stark as a fallback. |
| xjm | Certainly we are not going to get it done in three days if it is not already fixed, but we can at least update the instructions |
| quietone | Added an issue for noting the testing done and to be done for Classy, #3309319: Manually test upgrade core Classy to contrib Classy |
| Björn Brala (bbrala) | @xjm @quietone: i've gone through testing classy using bootstrap4 which uses classy as a base theme. Errors as expected when upgrading before requiring contrib. Tested both paths (first upgrade, or first install contrib). Set to RTBC - #3309319: Manually test upgrade core Classy to contrib Classy |
| Björn Brala (bbrala) | @lauriii had the same issues with the wsod as you mentioned. All looks like expected. |
| xjm | At what point does the WSOD happen exactly? |
| Björn Brala (bbrala) | upgrade to 10 with core module |
| xjm | I mean when exactly though? |
| xjm | Can you finish update.php? |
| Björn Brala (bbrala) | after upgrading core dependencies to 10 |
| Björn Brala (bbrala) | i use drush |
| xjm | So before you hit update.php the site is broken? |
| Björn Brala (bbrala) | it errors |
| xjm | But doesn't stop you? |
| xjm | When we tried it with modules Drush didn't stop you from upgrading |
| Björn Brala (bbrala) | let met remote into my home machine in a minute and check. |
| Björn Brala (bbrala) | in a meeting for next 20 miuntesn |
| Björn Brala (bbrala) | minutes |
| xjm | @Björn Brala (bbrala) No immediate rush -- just we need to give exact instructions for recovering from it if they screw it up because people will |
| Björn Brala (bbrala) | composer require drupal/[theme] then clear cache / update.php works, this i know.. |
| Björn Brala (bbrala) | As expected after upgrading to 10.xvagrant@bjorn-pc:/home/localcopy/drupal-classy $ drush updb [error] Bootstrap4 requires this module. (Currently using Unresolved dependency classy (Missing) ) In ThemeInitialization.php line 122: Base theme classy has not been installed. vagrant@bjorn-pc:/home/localcopy/drupal-classy $ composer require drupal/classyAfter that you can updb |
| quietone | I can add that to the 'recommendations' wiki page in the theme section. |
| Björn Brala (bbrala) | I'd say recommend to add contrib BEFORE upgrading to 10. Asumming you are on a supported version of core. |
| Kristen Pol (she/her) | Summary of status of issues above:3308518 (Meta) - Active3110137 - Fixed3309319 - RTBC |
| Gábor Hojtsy (he/him) | According to @lauriii this may still be possible before the beta thanks to work done by @phenaproxima #3308986: [Meta] Tasks to remove Stable theme from core and move to contrib |
| xjm | Note that we would also hold the beta for this, so this is another top priority, tied probably with the Classy manual testing above everything else (and second only to the JS updates) (edited) |
| Björn Brala (bbrala) | Added some instructions on how to manually test in the child issue of the removal. |
| Kristen Pol (she/her) | Status of child issues:3309176 - RTBC3309315 (manual testing) - Active |
| Björn Brala (bbrala) | Active? |
| Björn Brala (bbrala) | Ah, I did classy oops |
| Björn Brala (bbrala) | @Kristen Pol (she/her) I started tagging with :checked: when done. But didn't follow through completely :sweat_smile: |
| Gábor Hojtsy (he/him) | Raised by @xjm |
| Gábor Hojtsy (he/him) | #3269082: Remove HTML5 details collapse polyfill |
| longwave | I think this is ready but needs final review |
| Gábor Hojtsy (he/him) | @longwave currently has 1 fail?! (edited) |
| longwave | Oops, on my phone and didn't check the issue - it was close last time I looked! |
| Kristen Pol (she/her) | Note, this has been fixed :+1: (edited) |
| Gábor Hojtsy (he/him) | #3308821: Update stylelint-config-standard to 28.0.0 |
| Gábor Hojtsy (he/him) | raised by @xjm |
| longwave | will review this soon |
| Kristen Pol (she/her) | This one has been bumped back to "Needs work" |
| Gábor Hojtsy (he/him) | If you cannot make it but interested in following sessions live: https://twitter.com/DrupalConEur/status/1567845196024672257 🙂 |
| Kristen Pol (she/her) | The remote thing looks cool but, with time zones, everything should be happening when I'm normally asleep so not sure it's worth getting the remote ticket for me |
| Kristen Pol (she/her) | I wonder how fast the videos will be available... maybe it's worth it for that |
| gambry | I’ll be there, from Tuesday afternoon though. |
Comments
Comment #2
gábor hojtsyComment #12
gábor hojtsyComment #13
gábor hojtsy