Need to replace the dependency from jQuery once to core/once.

CommentFileSizeAuthor
#4 Screenshot 2022-05-04 at 10.46.08 PM.png125.55 KBshobhit_juyal
#2 gin_lab-jquery-dependency-from-once-3278775-2.patch570 byteschandansharma-88

Comments

shobhit_juyal created an issue. See original summary.

chandansharma-88’s picture

chandansharma-88 commented
StatusFileSize
new gin_lab-jquery-dependency-from-once-3278775-2.patch570 bytes

Hi,

Sharing the patch. Please review

shobhit_juyal’s picture

shobhit_juyal commented
Status: Active » Needs review
shobhit_juyal’s picture

shobhit_juyal commented
StatusFileSize
new Screenshot 2022-05-04 at 10.46.08 PM.png125.55 KB

Your patch works fine for me,

Thanks

shobhit_juyal’s picture

shobhit_juyal commented
Status: Needs review » Reviewed & tested by the community

Updating status to RTBC

christian.wiedemann’s picture

christian.wiedemann commented
Status: Reviewed & tested by the community » Needs work

Hi, but the scripts are using still jquery once. So I don't understand this patch?

shobhit_juyal’s picture

shobhit_juyal commented

@Christian.wiedemann,
Bascially it is replacing core/jQuery.once to core/once.

Please visit https://www.drupal.org/node/3158256 for more details.

christian.wiedemann’s picture

christian.wiedemann commented

I replaced jquery.once with once. Thanks for reporting.

christian.wiedemann’s picture

christian.wiedemann commented
Status: Needs work » Fixed
christian.wiedemann’s picture

christian.wiedemann commented
Status: Fixed » Closed (fixed)