Problem/Motivation

Unlinking linked inline images in text formats without HTML restrictions (which means the ckeditor5_htmlSupport plugin is loaded, which allows all HTML through CKE5's "GHS") fails.

Explicit test coverage was already added in #3246168: Images are not linkable through UI; already linked images are unlinked (data loss!). See the INLINE image, unrestricted test case.

Steps to reproduce

See write-up at https://github.com/ckeditor/ckeditor5/issues/10800.

Proposed resolution

Reproduced without Drupal's image-related overrides. Failed to find work-around. Therefore this is blocked on an upstream fix: https://github.com/ckeditor/ckeditor5/issues/10800

Remaining tasks

TBD

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
linked inline image.gif430.88 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Project: CKEditor 5 » Drupal core
Version: 1.0.x-dev » 10.0.x-dev
Component: Code » ckeditor5.module
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 10.0.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +stable blocker
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [upstream] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove » [upstream] [drupalImage] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [upstream] [drupalImage] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove » [PP-1] [upstream] [drupalImage] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove
Issue tags: -Needs upstream bugfix
Parent issue: » #3238333: Roadmap to CKEditor 5 stable in Drupal 9
Related issues: +#3277438: Update to CKEditor 5 v34.1.0

Looks like the next CKE5 release will fix this: https://github.com/ckeditor/ckeditor5/commit/b16a0a4675482c8a9de649f260f... 👍

So now marking this as blocked on #3277438: Update to CKEditor 5 v34.1.0.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » lauriii
Status: Postponed » Active

Just discussed in a meeting with the CKEditor 5 developers. @Reinmar asked that we could verify that https://github.com/ckeditor/ckeditor5/commit/b16a0a4675482c8a9de649f260f... indeed solved https://github.com/ckeditor/ckeditor5/issues/10800.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

For accessibility, please replace the animated GIF in the issue description with a video file, so that the site visitor has control over starting, stopping, pausing and replaying. This animation presents a barrier to me comprehending and participating in this issue.

Also, please spell out acronyms on first use.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] [upstream] [drupalImage] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove » [upstream] [drupalImage] Unlinking linked inline images while GHS is enabled: wrapping <a> is impossible to remove
Assigned: lauriii » Unassigned
Status: Active » Fixed

See #3277438-21: Update to CKEditor 5 v34.1.0 — this is now fixed! The automated test was updated, and I also manually confirmed this. 😄🥳

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.