[9.1] EventDispatcherInterface::dispatch() parameter argument order changed

Core isn't going to backport this change to D8 so fixing this deprecation will have to wait until we branch Rules and have a separate D9 branch. We still have a few years until D10, which is when this change will be required ...

-  $event_dispatcher = \Drupal::service('event_dispatcher');
+  $event_dispatcher = \Drupal::service('logger.ruleslog');

No, I don't want to do this. Rules needs to be able to react to any Symfony event, not just events generated through a Rules-specific mechanism. Plus this adds a mandatory Rules dependency to every contributed module that wants to provide Rules integration - right now those modules can just dispatch events whether or not Rules is enabled, and provide Rules plugins for conditions and actions which are just ignored if Rules is not installed. That wouldn't be true any more, and all those contributed modules would need to be changed.

This deprecation can be handled with a bunch of version_compare() calls, but we're going to have more and more of these non-BC changes in D9.1 as time goes on and each will require its own version_compare() - it's not going to be just this one. I really think this needs to be addressed in a separate minor branch after we switch to semantic versioning.- $event_dispatcher = \Drupal::service('event_dispatcher');
+ $event_dispatcher = \Drupal::service('logger.ruleslog');

Re-opening now that D8 is no longer supported.

We should be able to do this by following the instructions in the change record.

I'll work on that.

So, I changed almost every EventDispatcherInterface::dispatch() calls, but there is this one that I was not able to solve. There was this test called testTerminateEvent() and the call was like this:

// Manually trigger the initialization event.
    $dispatcher->dispatch(KernelEvents::TERMINATE);

A $event was missing, I was able to solve this problem at the testInitEvent() but I couldn't be able to do it in that testTerminateEvent(). I tried to create an event just like I did in the testInitEvent():

    $kernel = $this->container->get('kernel');
    $event = new RequestEvent($kernel, \Drupal::requestStack()->getCurrentRequest(), HttpKernelInterface::MASTER_REQUEST);
    $dispatcher->dispatch($event, KernelEvents::REQUEST);

creating an event, but when I try to create an TerminateEvent, it requests me a response parameter, and I was not able to get it.
So, I would like some suggestions if it is possible. Thank you!!

Your MR looks very good. I don't have an answer to your question right now, but I will look into it to see if I can find out what to do there.

I think in the case of EventIntegrationTest, for both testInitEvent() and testTerminateEvent(), you can just create a new Drupal\Component\EventDispatcher\Event and dispatch it as ->dispatch($event, KernelEvents::REQUEST) or ->dispatch($event, KernelEvents::TERMINATE). There is no context declared for these events in rules.rules.events.yml, so the only thing that really matters to Rules for these is the event name, since that's what we listen for and trigger on.

This is a Kernel test, and the test removes all other listeners for these events because we are only trying to verify that Rules responds to them correctly. So for test purposes this should work just fine.

thank you @TR I followed your suggestion. And also did a rebase. Thanks again

The MR needs to be rebased again - I'm not sure why, and I'm not sure why the auto rebase couldn't handle it. But also there are two unused use statements now, so I decided to just post a patch to update the MR.

@jonathan1055, do you want to add on the needed changes to .travis.yml for this fix? Drupal 9.1 is no longer supported, so we can fix D9.2 deprecations now, and it's nice to be aware of the new deprecations in D9.3 and D9.4.

Committed #16.

Yes, I'm aware of that, and have been running a fix for that locally for the past month or so. I have been doing some work with the event system and this is a little tricky to do in a BC way. I will post a patch in your new issue.