Bootstrap 4

Hi there :D

Yes we do but we need to wait until our base theme fully supports it.

https://drupal.org/project/bootstrap

Once they do then we will fully support it :D

I think it looks like Bootstrap 4 might be skipped and base theme will be going straight to Bootstrap 5 something for us to watch and look out for.

Somewhat based on this: #3212225: Remove Panelizer completely for 4.1.x line.

Since Layout Builder has sort of been decided to be the go-to layout option for WxT and since Bootstrap 3 is not entirely compatible with Layout Builder (numerous open issues on this but main one that seems to have carried over to WxT is that the tabs/breadcrumb blocks are broken in LB; also some more minor styling and js ones); wondering if much movement on this?

I have tested LB on a vanilla d9 site with base BS3 theme and i see the same issues as with a vanilla wxt site (4.1.x). Testing the vD9 site with BS4 and it works correctly. Also tested with BS5 and it works as well.

Not sure what you mean by BS4 being skipped; but yes, there is already a BS5 base theme available.

@LiquidCMS

upstream wxt wetboew libraries are currently on bootstrap 3.x

they've pretty much added everything to wetboew that bootstrap 4 has (and then some), so there's no missing functionality

an equal heights class and corresponding javascript for instance. (you no longer have to code a solution for this just use the wetboew provided class).

I don't think there's a need for bootstrap 4 at this time but even if there was I think it'd hinge on upstream.

wetboew is incredibly vast and all-encompassing

I could be mistaken though, not sure on the latest cutting edge upstream wetboew what they're doing, are they using bootstrap 4 yet?

alternatively to bootstrap theme, radix is bs4

@joseph.olstad, pretty sure bootstrap3 is not compatible with LB.. check out the issue queue. But, if you still think it is, can you send/post a screenshot of layout builder editor with the tabs and breadcrumb blocks placed?

perhaps i wasn't clear though.. i am not saying that the layouts created by LB are not compatible.. i am saying the LB UI is broken with BS3.

Have you tried using this module with Layout Builder?
https://www.drupal.org/project/bootstrap_layout_builder

If not, there's probably a patch lying around somewhere for this.

I believe this bootstrap_layout_builder module was created to resolve this issue so you might not need a patch.

yes I have observed this issue before and managed to find a way around it but been a flurry of activity going on and I can't recall all the details at the moment.

Yes, i had tried bs_lb; it doesnt fix this issue.. but perhaps they have a patch for it.

Posted a bug on this to the BSLB module: https://www.drupal.org/project/bootstrap_layout_builder/issues/3225923

That being said, guessing there are still other BS3 issues with LB and not sure WxT should be relying on that module to fix these when LB is certainly more compatible with BS4. Not to mention BS3 is pretty old.

I know there are significant changes form 3 to 4/5 but honestly not sure of the roadmap for these or if they are even part of the same project.. so i checked: https://blog.getbootstrap.com/2019/07/24/lts-plan/. It sounds as though BS3 was EOL back in 2019.

we might have our own issues as we're not vanilla bootstrap, this might be related to the wxt_bootstrap implementation/twig, Probably a fix for this.

do you get the same bug when switching to 'bootstrap' as default theme? (instead of wxt_bootstrap or your subtheme) when using bootstrap_layout_builder ?

Joe.. you're not listening to me.. lol

"I have tested LB on a vanilla d9 site with base BS3 theme and i see the same issues as with a vanilla wxt site (4.1.x). Testing the vD9 site with BS4 and it works correctly. Also tested with BS5 and it works as well."

This has nothing to do with WxT; LB is not compatible with BS3. There a bunch of issues open related to the various issues and they are in progress. My comment was just to add to this already open case to ask about plans to migrate WxT to a more recent version (BS5); especially now that LB is the default layout tool. If you have a solution to my specific issue; that's awesome and i would love to know what you use.. but no rush. I have work-arounds in place just none that will be allowed once we launch. But that isn't any time soon. But that isnt what this issue is about or what i was asking. :)

ah ok thanks for that gotcha, ok, surely there's a patch available somewhere no?

ya I managed to find some workarounds but they're inconvenient, like switching to another theme and making the change then switching back.
(bartik or other)

hmm, surprising no one has fixed this yet. Bootstrap is pretty popular, esp bs3.

ya this is an annoying and frustrating bug, I thought it was just my own environment that was causing this but good to know it wasn't just me.

I noticed that bootstrap_layout_builder module and wasn't sure if I fully explored that possibility as a fix, as I worked around the glitches by switching to bartik to make changes and then switching back after making the changes. Pretty annoying yes.

If you are using the layout builder with D8.9.x or D9.0.x and have non-routable links in your breadcrumb, it will crash unless you have this patch #3090941: Layout builder assumes all breadcrumb links are routable

This is fixed in Drupal 9.1.10 and 9.2.0

as for the bootstrap bug, would love a fix on that.

"ya I managed to find some workarounds but they're inconvenient, like switching to another theme and making the change then switching back. (bartik or other)"
- lol, yes, exactly what i meant by work-around that won't be very pleasant for the editors who will be using this.

"If you are using the layout builder with D8.9.x or D9.0.x and have non-routable links in your breadcrumb, it will crash unless you have this patch #3090941: Layout builder assumes all breadcrumb links are routable"
- were 9.1.11, so that's not it.

As mentioned, this was just a feeler to see what the WxT roadmap is as far as BS. It's a ways off for us to be an issue and i have already mentioned it to management that, depending on timing, I may need to get more involved. But not highest priority at the moment.

Thanks for the comments. I always assume there must be a ton of devs using WxT so i post things to get overall idea of what people are doing as far as best practices. But seems like only you, me and Will take much interest. :(

Hi everyone :D

Just though I would mention that yes at the moment we only stick to what wet-boew officially supports and departments are mandated to leverage. Right now that is still Bootstrap 3.

If at a future time a new release of wet-boew comes out that switches the base framework or even goes to Bootstrap 4 then we would definitely have to follow regardless of what that entails.

As I understand it, things are very much in flux and at least currently there are no plans to change anything (re Bootstrap 3).

I think some work is being done on evaluating a decoupled design of which I am a big proponent. I think they are looking at react (sadly not Vue.js) and more focuses on building reusable components.

On an unrelated note one thing i have been tasked with is adding the new intranet theme that is being worked on by ESDC but unfortunately their static templates only ever include the latest artifact replacing any older ones. Is a bit sad that the artifacts are linked as versions only on github pages rather than based on releases in github like all of the other themes.

https://cenw-wscoe.github.io/sgdc-cdts/docs/index-en.html

There is a patch available, it might need adjusting due to changes made since then.

If you can improve the patch before I do then itd be great
#3124174: Theme broken with layout builder

see my comment here:
#3225923-3: Some blocks are broken by (Bootstrap3 OR core_context?) in Layout Builder UI.

and here:

#3090941-12: Layout builder assumes all breadcrumb links are routable

#3230673: [WxT5] compatibility with Layout Builder.

so did #3212225: Remove Panelizer completely for 4.1.x line
fix this issue?

I am about to test this again in 4.1.x