Closed (fixed)
Project:
Token formatters
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Oct 2016 at 19:40 UTC
Updated:
6 Feb 2023 at 16:04 UTC
Jump to comment: Most recent
Comments
Comment #2
whiz11 commentedHave anybody started a port on Drupal 8?
Comment #3
whiz11 commentedComment #4
demonde commentedIs there any alternative approach in Drupal 8 for this module?
Comment #5
sandeepguntaka commentedHere is an initial code that i've written for D8 https://github.com/sandeepguntaka/token_formatters
Comment #6
adamps commented@Dave Reid please can you advise how we go forward? Are you willing for there to be a D8 version or should we create a separate module? Do you want to maintain D8 too, or would you prefer that someone else does it?
I also have a version - sorry I wrote the code before finding the comment from @sandeepguntaka. Good news is that the two versions are similar. My version has some potential advantages:
However there are still some gaps:
Comment #7
pasqualleComment #8
volegerCan be 2.0.x branch introduced for the development? The porting process has to start at some point, so this might help contributors propose changes by creating the issue forks based on the development branch.
Comment #9
geek-merlin@voleger You may want to trigger Taking over unsupported (abandoned) projects | Maintainership | Develop guide on Drupal.org
Comment #10
pasqualleor ping Dave Reid on slack for co-maintainer access..
Comment #11
volegerThanks @geek-merlin and @Pasqualle for suggestion.
I had asked for the co-maintainer role (via PM @Dave Reid in Drupal Slack).
Comment #14
carsoncho commentedHas there been any movement on this? I went ahead and created an issue fork to hopefully move this along. I took @sandeepguntaka's version of the module and made it the initial starting point for the 8.x branch.
I also added entity_reference_revisions as an available field type to be used.
Comment #16
adamps commentedPlease see #6, which has a version with some improvements.
Comment #14 states that the starting point was @sandeepguntaka's version from #5 which may be missing these improvements.
Comment #17
azinck commented@AdamPS: is your version of the module available somewhere? I don't see it linked anywhere.
Comment #18
adamps commentedI'm sorry you are right I never put a link. It is here: https://github.com/AdamPS/token_formatters.
Comment #19
adamps commentedI think that my code is a direct port - same formatter settings, same form UI text, everything the same as much as I was able to. As it says in #6 there are still some gaps:
I think @sandeepguntaka version changes lots of details that would make migration from D7 harder and it has more gaps (again see #6). However on the plus side it adds a test which would be good to keep.
Comment #20
adamps commentedI triggered the official process to take over an abandoned module: #3243341: Offering to maintain Token Formatters. If I succeed I can add others as maintainers - please let me know if you are interested.
Until then, anyone is welcome to contribute to the github version.
Comment #21
adamps commentedThey would not assign me as maintainer because apparently I don't have the "vetted" role. Maybe someone else would like to try?
Comment #22
minnur commentedDrupal 9 and 10 version support https://github.com/minnur/token_formatters
Comment #23
voleger@AdamPS I created a request #3328830: Offering to maintain Token Formatters
Comment #24
adamps commentedGreat thanks.
There are at least 3 versions:
This issue title is "Port Token formatters to Drupal 9/10". I feel we should try to do that - create as closely as possible an equivalent module that would make easy upgrade for the 700 remaining sites on the D7 version.
Comment #25
volegerOk, let's keep it up.
I'd created 1.0.x branch for Drupal 9.5/10.0 port.
Please create an MR for the initial commit. Based on already existing ports, we need an installable version in the dev branch ASAP. We can address the rest of the adjustments that need to be done in follow-up issues. #3335165: [META] Prepare 1.0.0 release
Comment #26
adamps commentedGreat nice work. Once there is a working release then I will create some new issues for improvements.
Comment #27
volegerOk, I'm going to merge 8.x-1x of the issue fork into 1.0.x branch.
Comment #29
volegerMerged! Thanks, see you at #3335165: [META] Prepare 1.0.0 release
Comment #30
voleger