Problem

Doesn’t meet contrast requirements in IE11, Firefox, or Edge

Steps to reproduce

Enable High Contrast mode in Windows

CommentFileSizeAuthor
#3 breadcrumb-after.jpg5.11 KBkatherined
#3 breadcrumb-before.jpg4.24 KBkatherined
#3 interdiff_2-3.txt2.75 KBkatherined
#3 3171727-3.patch2.85 KBkatherined
#2 3171727-2.patch2.45 KBkatherined

Comments

DyanneNova created an issue. See original summary.

katherined’s picture

katherined
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3171727-2.patch2.45 KB

This should bring the contrast to an acceptable ratio in high contrast modes.

katherined’s picture

katherined
she/her
Primary language English
commented
Issue summary: View changes
StatusFileSize
new 3171727-3.patch2.85 KB
new interdiff_2-3.txt2.75 KB
new breadcrumb-before.jpg4.24 KB
new breadcrumb-after.jpg5.11 KB

I think this is actually a much better approach, and covers Firefox in high-contrast mode. The only slight downside might be that the breadcrumb icon without high-contrast is now darker and matches the text, but I don't see a problem with that as it is barely visible, and there is a lot of upside.

Before:
light color breadcrumb icon

After:
dark color breadcrumb icon

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

the breadcrumb icon without high-contrast is now darker and matches the text

Looks 👍 on a design perspective. Agreed with @katherined about not being a problem because it's a really small change.

  • lauriii committed 1bfea45 on 9.1.x 
    Issue #3171727 by katherined, DyanneNova, ckrina: Claro breadcrumb...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 1bfea45 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.