Remove system.module BC layers

It should not be blocked on the deprecation of constants because @alexpott said it will be ready for work in 9.1

+++ /dev/null
@@ -1,76 +0,0 @@
-/**
- * @coversDefaultClass \Drupal\Core\Path\AliasStorage
- *
- * @group path
- * @group legacy
- */
-class DeprecatedPathHooksTest extends KernelTestBase {

This overlaps with #3092090: Remove legacy Path Alias subsystem, I don't think the implementation of this actually gets removed here as that is in path_alias module. I'd suggest to remove it from this patch.

Reroll. Also removing core/modules/system/src/Plugin/views/field/BulkForm.php now that the update path is gone.

There are a few left-over deprecated things that we apparently can't remove yet, as they are still used (constants, test trait) or are actually testing the deprecation handling itself.

Yay, so removing BulkForm works now too. Fixed the plugin test, the media_library test looks like a random fail.

There are a few left-over deprecated things that we apparently can't remove yet, as they are still used (constants, test trait) or are actually testing the deprecation handling itself.

Ideally we'd have a follow-up issue created that lists those. But … I don't think neither the existence of the follow-up issue nor the need for a follow-up issue should block this. Because

33 files changed, 8 insertions, 3361 deletions.

… goes a very substantial way towards getting to a point of having no more deprecated code in Drupal 9 core, and hence gets us closer to 9.0.0. This will help get the chart at https://dev.acquia.com/drupal9/deprecation_status/graphs a lot closer to zero.

(This patch removes 27 occurrences of @deprecated, or 8% of the remaining ones as of Monday January 20.)

Reviewed the entire patch. This looks ready :) 🚢

also removing core/modules/system/src/Plugin/views/field/BulkForm.php now that the update path is gone.

D'oh, just noticed

  /**
   * List of deprecated plugin classes.
   *
   * @var string[]
   */
  protected $deprecatedPlugins = [
    'Drupal\system\Plugin\views\field\BulkForm',
  ];

in \Drupal\Tests\views\Kernel\PluginInstanceTest. We'll need to remove that too, since this patch is removing that class.

Sorry, @Berdir :)

Patch attached removes the deprecatedPlugins check as suggested in #15.

Woah, you were on that really fast, @JeroenT, thanks! 🙏

+++ b/core/modules/views/tests/src/Kernel/PluginInstanceTest.php
@@ -87,23 +78,17 @@
    * filtering out deprecated plugins.

🤓 Nit: This comment has not yet been updated.

D'oh, nope, we can't do most of what's in #16, no matter how tempting it is 😞 Because it ironically would itself introduce a BC break!

The BC break here is that contrib/custom modules may be subclassing \Drupal\Tests\views\Kernel\PluginInstanceTest and may be expanding the deprecatedPlugins class property and/or they may be calling ::assertPluginInstances(FALSE). The #16 interdiff would break those modules, without that first having been deprecated.

So, all of #16 needs to be reverted, and we just need the deprecatedPlugins class property to be set to the empty array.

🤦‍♂️Reverted #16 and replaced the deprecatedPlugins property with an empty array.

Perfect, thanks!

Nice!

Committed 46bd90d and pushed to 9.0.x. Thanks!

As far as I can see follow-ups exist for the things that are still deprecated.