Needs work
Project:
Views PHP
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jan 2019 at 07:15 UTC
Updated:
23 Nov 2020 at 14:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nor sairi commentedComment #3
aayush23 commentedI have created a patch for this. Please find a patch below.
Comment #4
aayush23 commentedComment #5
aayush23 commentedComment #6
nor sairi commented#3, tested and its work. tq aayush
Comment #7
nor sairi commentedComment #8
tobiasbSee #2274543: [7.x-1.x] Remove usage of deprecated create_function()
Comment #9
gerson.analista commentedI think that this issue is not duplicate.
The issue #2274543: Remove usage of deprecated create_function() calls for PHP 7.2+ future proofing - https://www.drupal.org/project/views_php/issues/2274543 is for Drupal 7.
I believe the most correct would be to add as a related issue.
Comment #10
gerson.analista commented#3, tested and its work. thanks aayush
Comment #11
tobiasbIn the normal way, we should create a patch for D8 and then backport it for D7. But I can also life with two issues. ;-)
Comment #12
nor sairi commentedComment #13
joseph.olstadIn D7 , this technique had issues in combination with VBO, so we ended up using the closure library instead.
It is likely that the D8 solution using the 'eval' function above may have the same complication in combination with VBO in D8.
If so, please review the D7 patch for how it is done.
#2274543-100: [7.x-1.x] Remove usage of deprecated create_function()
the authors of the closure library helped us figure this out.
Comment #14
proweb.ua commented#3 works
Comment #15
promo-il commentedComment #16
liam morlandThe patch in #3 may have object serialization problems since functions are assigned to object properties. This is avoided in the approach taken for D7 in #2274543-180: [7.x-1.x] Remove usage of deprecated create_function().
Comment #17
anybody@Liam Morland So we should set this back to Needs work?
Comment #18
liam morland