Problem/Motivation

The style plugin can be added on a paragraph type.

Currentls it's a multiple select element combined with ajax.
That's cumbersome to deal with, using ctrl and scroll in a tiny element.

Proposed resolution

Switch to checkboxes to enable each style group.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-2956136-3-5.txt14.66 KBjohnchque
#5 enable_styles_checkboxes-2956136-5.patch16.7 KBjohnchque
#3 enable_styles_checkboxes-2956136-3.patch1.95 KBjohnchque

Comments

miro_dietiker created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Assigned: Unassigned » johnchque

Working on this. :)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new enable_styles_checkboxes-2956136-3.patch1.95 KB

Not sure how many tests this might break, uploading to check that.

Status: Needs review » Needs work

The last submitted patch, 3: enable_styles_checkboxes-2956136-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new enable_styles_checkboxes-2956136-5.patch16.7 KB
new interdiff-2956136-3-5.txt14.66 KB

Fixing tests. :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Looks good, tested manually a bit as well.

  • Berdir committed c47b572 on 8.x-1.x authored by yongt9412 
    Issue #2956136 by yongt9412: Enable styles with checkboxes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.